Differential D2068

test_storage: Use the db_transaction context manager instead of raw connections
ClosedPublic
Actions

Authored by olasd on Oct 2 2019, 5:25 PM.

Details

Reviewers

Group Reviewers

Commits

rDSTOC3228b18eeba9: test_storage: Use the db_transaction context manager instead of raw connections
rDSTO3228b18eeba9: test_storage: Use the db_transaction context manager instead of raw connections

Summary

This minimizes the risk of dangling db connections, which in turn reduces the
chance of cascading test failures.

Depends on D2067

Test Plan

tox runs without issue

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Oct 2 2019, 5:25 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 2 2019, 5:25 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/664/ for more details.

Harbormaster completed remote builds in B8087: Diff 6944.Oct 2 2019, 5:46 PM

Looks clearer indeed.

This revision is now accepted and ready to land.Oct 2 2019, 5:57 PM

Closed by commit rDSTO3228b18eeba9: test_storage: Use the db_transaction context manager instead of raw connections (authored by olasd). · Explain WhyOct 2 2019, 5:57 PM

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rDSTO3228b18eeba9: test_storage: Use the db_transaction context manager instead of raw connections.

olasd added a commit: rDSTOC3228b18eeba9: test_storage: Use the db_transaction context manager instead of raw connections.Oct 30 2019, 5:22 PM

Revision Contents
Changeset List

Path

Size

swh/

storage/

tests/

test_storage.py

74 lines

Diff 6949

View Options

swh/storage/tests/test_storage.py

test_storage: Use the db_transaction context manager instead of raw connectionsClosedPublicActions