Differential D2067

test_storage: introduce a db_transaction context manager
ClosedPublic
Actions

Authored by olasd on Oct 2 2019, 5:24 PM.

Details

Reviewers

Group Reviewers

Commits

rDSTOC4c2c311a775f: test_storage: introduce a db_transaction context manager
rDSTO4c2c311a775f: test_storage: introduce a db_transaction context manager

Summary

This wraps the steps needed to get a (properly wrapped) db object and run a
transaction on it so we avoid repeating ourselves

Depends on D2066

Test Plan

no functional changes either

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Oct 2 2019, 5:24 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 2 2019, 5:24 PM

olasd added a child revision: D2068: test_storage: Use the db_transaction context manager instead of raw connections.Oct 2 2019, 5:25 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/663/ for more details.

Harbormaster completed remote builds in B8086: Diff 6943.Oct 2 2019, 5:42 PM

anlambert accepted this revision.Oct 2 2019, 5:54 PM

This revision is now accepted and ready to land.Oct 2 2019, 5:54 PM

Closed by commit rDSTO4c2c311a775f: test_storage: introduce a db_transaction context manager (authored by olasd). · Explain WhyOct 2 2019, 5:57 PM

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rDSTO4c2c311a775f: test_storage: introduce a db_transaction context manager.

olasd added a commit: rDSTOC4c2c311a775f: test_storage: introduce a db_transaction context manager.Oct 30 2019, 5:22 PM

Revision Contents
Changeset List

Path

Size

swh/

storage/

tests/

test_api_client.py

6 lines

test_storage.py

10 lines

Diff 6948

View Options

swh/storage/tests/test_api_client.py