Differential D2066

Postgres storage: introduce a db() context manager
ClosedPublic
Actions

Authored by olasd on Oct 2 2019, 5:24 PM.

Details

Reviewers

Group Reviewers

Commits

rDSTOC9bbd5e2344d8: Postgres storage: introduce a db() context manager
rDSTO9bbd5e2344d8: Postgres storage: introduce a db() context manager

Summary

This helper avoids us repeating the get_db/put_db pattern all the time.

Depends on D2064 because CI is broken without it

Test Plan

no functional change

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Oct 2 2019, 5:24 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 2 2019, 5:24 PM

olasd added a child revision: D2067: test_storage: introduce a db_transaction context manager.Oct 2 2019, 5:24 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/662/ for more details.

Harbormaster completed remote builds in B8085: Diff 6942.Oct 2 2019, 5:37 PM

anlambert accepted this revision.Oct 2 2019, 5:53 PM

This revision is now accepted and ready to land.Oct 2 2019, 5:53 PM

Closed by commit rDSTO9bbd5e2344d8: Postgres storage: introduce a db() context manager (authored by olasd). · Explain WhyOct 2 2019, 5:57 PM

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rDSTO9bbd5e2344d8: Postgres storage: introduce a db() context manager.

olasd added a commit: rDSTOC9bbd5e2344d8: Postgres storage: introduce a db() context manager.Oct 30 2019, 5:22 PM

Revision Contents
Changeset List

Path

Size

swh/

storage/

storage.py

11 lines

Diff 6947

View Options

Postgres storage: introduce a db() context managerClosedPublicActions