Page MenuHomeSoftware Heritage

Move to streaming decompression API
ClosedPublic

Authored by olasd on Sep 30 2019, 10:30 PM.

Details

Summary

This allows us to detect whether the (compressed) object got corrupted with
trailing data, which the plain decompress() api doesn't allow.

This will be useful in further diffs

Depends on D2044

Test Plan

tox

Diff Detail

Repository
rDOBJS Object storage
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 8009
Build 11547: tox-on-jenkinsJenkins
Build 11546: arc lint + arc unit

Event Timeline

douardda requested changes to this revision.Oct 1 2019, 9:32 AM

I would expect a (series of) test(s) with statements like with pytest.raises(Error, match='Corrupt object') somewhere in this diff.

This revision now requires changes to proceed.Oct 1 2019, 9:32 AM

Adding tests 2 or 3 diffs after is a bold move... UNFAIR :-)

This revision is now accepted and ready to land.Oct 1 2019, 9:38 AM
This revision was automatically updated to reflect the committed changes.