Differential D1984

Phabricator: Fix get_next_target_from_response return type
ClosedPublic
Actions

Authored by anlambert on Sep 16 2019, 1:38 PM.

Details

Reviewers

ardumont

Maniphest Tasks

T1997: lister-phabricator: Pagination error

Commits

rDLSe83902c2a36a: phabricator/lister: Fix get_next_target_from_response return type

Summary

Without that fix, errors are raised when one wants to list Phabricator repositories
in a specific index range. The issue is due to a comparison between a string and
an integer. So convert next extracted repository index to integer to match the
corresponding model type.

Depends on D1982

Closes T1997

Test Plan

A new test has been added for range listing.

Diff Detail

Repository

rDLS Listers

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Sep 16 2019, 1:38 PM

anlambert retitled this revision from phabricator/lister: Fix get_next_target_from_response return type to Phabricator lister: Fix get_next_target_from_response return type.Sep 16 2019, 1:39 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLS/job/tox/368/ for more details.

Harbormaster completed remote builds in B7795: Diff 6697.Sep 16 2019, 1:41 PM

anlambert retitled this revision from Phabricator lister: Fix get_next_target_from_response return type to Phabricator: Fix get_next_target_from_response return type.Sep 16 2019, 8:28 PM

anlambert added a child revision: D1990: Phabricator: Prevent erroneous scheduler tasks disabling.

ardumont accepted this revision.Sep 17 2019, 6:34 AM

This revision is now accepted and ready to land.Sep 17 2019, 6:34 AM

Closed by commit rDLSe83902c2a36a: phabricator/lister: Fix get_next_target_from_response return type (authored by anlambert). · Explain WhySep 17 2019, 10:52 AM

This revision was automatically updated to reflect the committed changes.