Page MenuHomeSoftware Heritage

Phabricator: Fix get_next_target_from_response return type
ClosedPublic

Authored by anlambert on Sep 16 2019, 1:38 PM.

Details

Summary

Without that fix, errors are raised when one wants to list Phabricator repositories
in a specific index range. The issue is due to a comparison between a string and
an integer. So convert next extracted repository index to integer to match the
corresponding model type.

Depends on D1982

Closes T1997

Test Plan

A new test has been added for range listing.

Diff Detail

Repository
rDLS Listers
Branch
phabricator-lister-fix-index-type
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 7795
Build 11208: tox-on-jenkinsJenkins
Build 11207: arc lint + arc unit

Event Timeline

anlambert retitled this revision from phabricator/lister: Fix get_next_target_from_response return type to Phabricator lister: Fix get_next_target_from_response return type.Sep 16 2019, 1:39 PM
anlambert retitled this revision from Phabricator lister: Fix get_next_target_from_response return type to Phabricator: Fix get_next_target_from_response return type.Sep 16 2019, 8:28 PM
This revision is now accepted and ready to land.Sep 17 2019, 6:34 AM
This revision was automatically updated to reflect the committed changes.