Page MenuHomeSoftware Heritage
Differential D1671

api/async: fix json decoder and add a few tests for the asynchronous api code
ClosedPublic
Actions

Authored by douardda on Jul 1 2019, 1:42 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
rDCORE9078d279b0d5: tests: make test_statsd more robust when executed along other asyncio-based…
rDCOREb5a48c4f0f8b: api: fix json decoder
rDCORE60a114df7f8d: tests: add a few tests for the asynchronous api code
Summary

Note that test_post_struct_json is failing with current implementation,
the fix comes with the second revision in this diff:

json.loads() expect a str, not a bytes.

Depends on D1670.

Diff Detail

Repository
rDCORE Foundations and core functionalities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Jul 1 2019, 1:42 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJul 1 2019, 1:42 PM
swh-public-ci added a comment.Jul 1 2019, 1:49 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCORE/job/tox/234/
See console output for more information: https://jenkins.softwareheritage.org/job/DCORE/job/tox/234/console

Harbormaster failed remote builds in B6596: Diff 5588!Jul 1 2019, 1:49 PM
swh-public-ci added a comment.Jul 1 2019, 1:56 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/235/ for more details.

douardda updated this revision to Diff 5592.Jul 1 2019, 3:09 PM

rebase + apply class renamings from D1670

swh-public-ci added a comment.Jul 1 2019, 3:17 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/237/ for more details.

Harbormaster completed remote builds in B6600: Diff 5592.Jul 1 2019, 3:17 PM
douardda updated this revision to Diff 5593.Jul 1 2019, 3:21 PM

Add a fix for collateral damaged test_statsd.py

swh-public-ci added a comment.Jul 1 2019, 3:27 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/238/ for more details.

Harbormaster completed remote builds in B6601: Diff 5593.Jul 1 2019, 3:27 PM
vlorentz accepted this revision.Jul 1 2019, 4:20 PM
This revision is now accepted and ready to land.Jul 1 2019, 4:20 PM
douardda updated this revision to Diff 5665.Jul 4 2019, 12:11 PM

rebased

swh-public-ci added a comment.Jul 4 2019, 12:14 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/240/ for more details.

Harbormaster completed remote builds in B6675: Diff 5665.Jul 4 2019, 12:14 PM
Closed by commit rDCORE60a114df7f8d: tests: add a few tests for the asynchronous api code (authored by douardda). · Explain WhyJul 4 2019, 12:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
swh/
core/
api/
tests/
115 lines

Diff 5667

View Options

swh/core/api/tests/test_async.py

Loading...
About · Developer information · Legal