api: rename several API related classes
ClosedPublic
Actions

swh/core/api/asynchronous.py
52	Can we please drop the SWH prefix? I try to remove that bit by bit everywhere i can. The module already specifies we are within the swh environment, so no need to be extra redundant.

douardda added inline comments.Jul 1 2019, 2:13 PM

swh/core/api/asynchronous.py
52	ok but then I need to drop it also in the sync version of the code...

Rename several API classes

The first git revision does the renamings in the code:

sync:
- SWHServerAPIApp => RPCServerApp
- MetaSWHRemoteAPI => MetaRPCClient
- SWHRemoteAPI => RPCClient
async:
- SWHRemoteAPI => RPCServerApp (!)

The second revision updates the tests accordingly

Tests pass OK before and after this second revision.

douardda retitled this revision from api/async: rename SWHRemoteAPI as SWHServerAPIApp to api: rename several API related classes.Jul 1 2019, 3:06 PM

douardda edited the summary of this revision. (Show Details)

I don't think we should add a dependency just for that. Raising a warning directly (like swh-storage already does) would work

Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/236/ for more details.

Harbormaster completed remote builds in B6597: Diff 5589.Jul 1 2019, 3:11 PM

In D1670#38521, @vlorentz wrote:

I don't think we should add a dependency just for that. Raising a warning directly (like swh-storage already does) would work

I think we should have such a facility in swh.core and use it everywhere consistently. Using plain DeprecationWarning is a pain in the neck, does not encourage you to declare which version adds the deprecation, and so on. This goes towards a more declarative deprecation handling, which is better.

vlorentz accepted this revision.Jul 1 2019, 4:23 PM

This revision is now accepted and ready to land.Jul 1 2019, 4:23 PM

"ok then"

ardumont accepted this revision.Jul 1 2019, 4:31 PM