Page MenuHomeSoftware Heritage
Differential D1558

Add support for using URL instead of ID in origin_visit_{add,update}.
ClosedPublic
Actions

Authored by vlorentz on Jun 6 2019, 5:04 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Summary

Depends on D1557.

Diff Detail

Repository
rDSTO Storage manager
Branch
origin_visit_add_from_url
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6083
Build 8375: tox-on-jenkinsJenkins
Build 8374: arc lint + arc unit

Event Timeline

vlorentz created this revision.Jun 6 2019, 5:04 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJun 6 2019, 5:04 PM
swh-public-ci added a comment.Jun 6 2019, 5:10 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/457/ for more details.

Harbormaster completed remote builds in B6069: Diff 5120.Jun 6 2019, 5:10 PM
vlorentz added a child revision: D1559: Add support for using URL instead of ID in snapshot_get_latest..Jun 7 2019, 11:11 AM
ardumont accepted this revision.Jun 7 2019, 2:10 PM
ardumont added a subscriber: ardumont.

Sounds good as well, just a small adaptation needed.

swh/storage/storage.py
1228

Add missing db=db, cur=cur parameters as in line 1198 (of this file)

This revision is now accepted and ready to land.Jun 7 2019, 2:10 PM
vlorentz updated this revision to Diff 5134.Jun 7 2019, 2:18 PM

Pass db+cur and deduplicate calls to origin_get.

swh-public-ci added a comment.Jun 7 2019, 2:25 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/460/ for more details.

Harbormaster completed remote builds in B6083: Diff 5134.Jun 7 2019, 2:25 PM
vlorentz closed this revision.Jun 11 2019, 1:22 PM

Landed as 0386716680da9032ba01fc34266ba96097420f67

Revision Contents
Changeset List

PathSize
swh/
storage/
14 lines
21 lines
tests/
40 lines

Diff 5134

View Options

swh/storage/in_memory.py

Loading...
View Options

swh/storage/storage.py

Loading...
View Options

swh/storage/tests/test_storage.py

Loading...
About · Developer information · Legal