If it is not specified when calling origin_visit_add, it defaults to the origin's type.
Note: I did not test the migration script.
Details
Details
- Reviewers
ardumont - Group Reviewers
Reviewers - Maniphest Tasks
- T1731: Intrinsic identifiers for origins
Diff Detail
Diff Detail
- Repository
- rDSTO Storage manager
- Branch
- origin_visit_type
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 6090 Build 8388: tox-on-jenkins Jenkins Build 8387: arc lint + arc unit
Event Timeline
Comment Actions
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/454/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/454/console
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/456/ for more details.
Comment Actions
Sound good.
Just a couple of questions.
| sql/upgrades/136.sql | ||
|---|---|---|
| 13 | loader | |
| 22 | So we keep the type on the origin for now, right? | |
| swh/storage/sql/30-swh-schema.sql | ||
| 221 | loader | |
| swh/storage/storage.py | ||
| 1278–1281 | why did you drop the db and cur parameter? My understanding was to stay within the same transaction, we need to pass those along. | |
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/461/ for more details.
| swh/storage/storage.py | ||
|---|---|---|
| 1187 | I missed db=db, cur=cur here as well. | |
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/462/ for more details.
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/463/ for more details.
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/464/ for more details.