Paths

Table of Contentst

Differential D1557

Add a 'type' column to origin_visit.
ClosedPublic
Actions

Authored by vlorentz on Jun 6 2019, 4:17 PM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Maniphest Tasks

T1731: Intrinsic identifiers for origins

Summary

If it is not specified when calling origin_visit_add, it defaults to the origin's type.

Note: I did not test the migration script.

Diff Detail

Repository

rDSTO Storage manager

Branch

origin_visit_type

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 6090
Build 8388: tox-on-jenkins	Jenkins
Build 8387: arc lint + arc unit

Event Timeline

vlorentz created this revision.Jun 6 2019, 4:17 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 6 2019, 4:17 PM

vlorentz added a task: T1731: Intrinsic identifiers for origins.Jun 6 2019, 4:18 PM

vlorentz edited the summary of this revision. (Show Details)

vlorentz edited the summary of this revision. (Show Details)

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/454/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/454/console

Harbormaster failed remote builds in B6064: Diff 5114!Jun 6 2019, 4:32 PM

update api client

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/456/ for more details.

Harbormaster completed remote builds in B6068: Diff 5119.Jun 6 2019, 4:47 PM

vlorentz added a child revision: D1558: Add support for using URL instead of ID in origin_visit_{add,update}..Jun 6 2019, 5:04 PM

Sound good.

Just a couple of questions.

sql/upgrades/136.sql
12	loader
21	So we keep the type on the origin for now, right?
swh/storage/sql/30-swh-schema.sql
220	loader
swh/storage/storage.py
1278–1281	why did you drop the db and cur parameter? My understanding was to stay within the same transaction, we need to pass those along.

fix typos + cur/db.

vlorentz marked 3 inline comments as done.Jun 7 2019, 2:22 PM

vlorentz added inline comments.

sql/upgrades/136.sql
21	Yes, we'll keep it while I'm migrating clients.
swh/storage/storage.py
1278–1281	my mistake

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/461/ for more details.

Harbormaster completed remote builds in B6084: Diff 5135.Jun 7 2019, 2:31 PM

Better migration script

Better migration script

ardumont added inline comments.Jun 7 2019, 2:37 PM

swh/storage/storage.py
1186	I missed db=db, cur=cur here as well.

ardumont accepted this revision.Jun 7 2019, 2:39 PM

This revision is now accepted and ready to land.Jun 7 2019, 2:39 PM

Pass db/cur

vlorentz marked an inline comment as done.Jun 7 2019, 2:40 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/462/ for more details.

Harbormaster completed remote builds in B6088: Diff 5138.Jun 7 2019, 2:41 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/463/ for more details.

Harbormaster completed remote builds in B6089: Diff 5139.Jun 7 2019, 2:47 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/464/ for more details.

Harbormaster completed remote builds in B6090: Diff 5140.Jun 7 2019, 2:53 PM

Landed as 21b5142164d81abbebbed5d82954f7e4ac1e5556

vlorentz mentioned this in T1891: Make 'type' an attribute of origin visits, not origins.Jul 8 2019, 1:18 PM

Revision Contents
Changeset List

Path

Size

sql/

upgrades/

41 lines

swh/

storage/

api/

6 lines

16 lines

11 lines

sql/

30-swh-schema.sql

2 lines

40-swh-func.sql

6 lines

22 lines

tests/

test_storage.py

88 lines

Diff 5140

sql/upgrades/136.sql

Loading...

swh/storage/api/client.py

Loading...

swh/storage/db.py

Loading...

swh/storage/in_memory.py

Loading...

swh/storage/sql/30-swh-schema.sql

Loading...

swh/storage/sql/40-swh-func.sql

Loading...

swh/storage/storage.py

Loading...

swh/storage/tests/test_storage.py

Loading...