Page MenuHomeSoftware Heritage
Differential D1559

Add support for using URL instead of ID in snapshot_get_latest.
ClosedPublic
Actions

Authored by vlorentz on Jun 6 2019, 5:05 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers

Diff Detail

Repository
rDSTO Storage manager
Branch
snapshot_get_latest_from_url
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6070
Build 8353: tox-on-jenkinsJenkins
Build 8352: arc lint + arc unit

Event Timeline

vlorentz created this revision.Jun 6 2019, 5:05 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJun 6 2019, 5:05 PM
swh-public-ci added a comment.Jun 6 2019, 5:15 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/458/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/458/console

Harbormaster failed remote builds in B6070: Diff 5121!Jun 6 2019, 5:15 PM
vlorentz added a parent revision: D1558: Add support for using URL instead of ID in origin_visit_{add,update}..Jun 7 2019, 11:11 AM
swh-public-ci added a comment.Jun 7 2019, 11:17 AM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/459/ for more details.

Harbormaster completed remote builds in B6070: Diff 5121.Jun 7 2019, 11:17 AM
ardumont accepted this revision.Jun 7 2019, 2:16 PM
ardumont added a subscriber: ardumont.

Same remark as T1557, T1558 about the missing parameters.
Otherwise, sounds good!

swh/storage/storage.py
1067

cur=cur, db=db!

This revision is now accepted and ready to land.Jun 7 2019, 2:16 PM
vlorentz added a child revision: D1564: Manipulate origin URLs instead of origin ids..Jun 7 2019, 4:24 PM
vlorentz removed a child revision: D1564: Manipulate origin URLs instead of origin ids..
vlorentz added a child revision: D1564: Manipulate origin URLs instead of origin ids..Jun 7 2019, 4:32 PM
vlorentz removed a child revision: D1564: Manipulate origin URLs instead of origin ids..Jun 11 2019, 10:01 AM
vlorentz added a child revision: D1564: Manipulate origin URLs instead of origin ids..Jun 11 2019, 10:20 AM
vlorentz added a comment.Jun 11 2019, 1:22 PM

Landed as 5a9f544bf08dc169511ae3b467a935566dff643c.

vlorentz closed this revision.Jun 11 2019, 1:22 PM

Revision Contents
Changeset List

PathSize
swh/
storage/
4 lines
5 lines
tests/
62 lines

Diff 5121

View Options

swh/storage/in_memory.py

Loading...
View Options

swh/storage/storage.py

Loading...
View Options

swh/storage/tests/test_storage.py

Loading...
About · Developer information · Legal