Page MenuHomeSoftware Heritage
Differential D1469

setup: register the indexer cli subcommand
ClosedPublic
Actions

Authored by douardda on May 15 2019, 2:59 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDCIDX2f32fe893ba0: cli: reword the main cli's docstring
rDCIDX00234cbbbbcf: cli: import CONTEXT_SETTINGS from swh.core
rDCIDX43f7c89298e6: setup: register the indexer cli subcommand
rDCIDX6d0e61a00aad: cli: define main cli group's name as 'indexer'
Summary

and define main cli group's name as 'indexer'
so the completion of the main 'swh' commands works properly.

related to T1671.

Diff Detail

Repository
rDCIDX Metadata indexer
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.May 15 2019, 2:59 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptMay 15 2019, 2:59 PM
swh-public-ci added a comment.May 15 2019, 3:02 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/530/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/530/console

Harbormaster failed remote builds in B5718: Diff 4819!May 15 2019, 3:02 PM
ardumont added a subscriber: ardumont.May 15 2019, 3:19 PM
ardumont added inline comments.
swh/indexer/cli.py
18

Can't we use the one from swh.core.cli (since it's the same)?

ardumont accepted this revision.May 15 2019, 3:21 PM
ardumont added inline comments.
swh/indexer/cli.py
18

Well, it's consistent with the rest but still ;)

This revision is now accepted and ready to land.May 15 2019, 3:21 PM
douardda added inline comments.May 15 2019, 4:55 PM
swh/indexer/cli.py
18

ok ok ok will do

douardda updated this revision to Diff 4834.May 15 2019, 5:16 PM

cli: import CONTEXT_SETTINGS from swh.core

Harbormaster failed remote builds in B5734: Diff 4834!May 15 2019, 5:19 PM
swh-public-ci added a comment.May 15 2019, 5:19 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/531/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/531/console

douardda updated this revision to Diff 4836.May 15 2019, 5:39 PM

rebased on D1478

depends on D1478

douardda added a parent revision: D1478: tests: make test_cli.py compatible with scheduler 0.0.56.May 15 2019, 5:40 PM
swh-public-ci added a comment.May 15 2019, 5:42 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/533/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/533/console

Harbormaster failed remote builds in B5736: Diff 4836!May 15 2019, 5:42 PM
swh-public-ci added a comment.May 15 2019, 5:46 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/534/ for more details.

douardda added a child revision: D1480: cli: rename the api-server command as rpc-serve.May 16 2019, 4:26 PM
This revision was landed with ongoing or failed builds.May 17 2019, 10:44 AM
Closed by commit rDCIDX6d0e61a00aad: cli: define main cli group's name as 'indexer' (authored by douardda). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
swh/
indexer/
2 lines

Diff 4862

View Options

swh/indexer/cli.py

Loading...
About · Developer information · Legal