- deposit_read: Compute origin-url from the deposit's setup
- check: Remove url and external_identifier from mandatory fields
More a question than a request of change (because I'm new to this code base), but where in this change we verify that *an* external_id is actually present and not simply missing? It is totally right to make external_id optional *as a metadata field*, but it should not be missing entirely---the client should be providing an UUID if it's not being provided by other means. In that case, though, the code that generate the complete URL should check that, one way or another, *an* external_id is present, as a safety net.
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DDEP/job/tox/116/
See console output for more information: https://jenkins.softwareheritage.org/job/DDEP/job/tox/116/console
So far, we don't check.
In the current workflow with hal, it is provided (and i don't expect that to change because the slug is still mandatory on the api).
I can add the check but i'm not sure what to do if the cases arise, raising?
My point is that *today* we are sure it's around, but tomorrow the code that make sure the ID is there might be changed and, when that happens, we will not notice that is missing and will start filling the archive with URLs that only contain the domain name and no ID. Please add the check (an assertion would be enough) as a classic defensive programming measure.