Page MenuHomeSoftware Heritage
Differential D1381

Use the db_transaction decorator on all _add() methods.
ClosedPublic
Actions

Authored by vlorentz on Apr 9 2019, 4:41 PM.

Details

Reviewers
ardumont
olasd
Group Reviewers
Reviewers
Commits
rDSTOCcf99702f18fc: Use the db_transaction decorator on all _add() methods.
rDSTOcf99702f18fc: Use the db_transaction decorator on all _add() methods.
Summary

So they gracefully release the connection on error instead
of relying on reference-counting to call the Db's __del__
(which does not happen in Hypothesis tests) because a ref
to it is kept via the traceback object.

Depends on D1380.

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Apr 9 2019, 4:41 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptApr 9 2019, 4:41 PM
vlorentz mentioned this in D1384: Explicitely give Db connections back to the pool..Apr 9 2019, 4:56 PM
swh-public-ci added a comment.Apr 9 2019, 4:56 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/333/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/333/console

Harbormaster failed remote builds in B5243: Diff 4435!Apr 9 2019, 4:56 PM
swh-public-ci added a comment.Apr 9 2019, 5:29 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/343/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/343/console

ardumont accepted this revision.Apr 9 2019, 5:43 PM
ardumont added a subscriber: ardumont.

Consistency love!

This revision is now accepted and ready to land.Apr 9 2019, 5:43 PM
olasd accepted this revision.Apr 9 2019, 5:44 PM
olasd added a subscriber: olasd.

LGTM, thanks!

swh/storage/storage.py
839–842

Unnecessary listification here

845–846

Bad @vlorentz trying to introduce a DoS in prod.

vlorentz updated this revision to Diff 4464.Apr 9 2019, 5:46 PM
  • Remove debugging stuff
Harbormaster failed remote builds in B5272: Diff 4464!Apr 9 2019, 5:47 PM
swh-public-ci added a comment.Apr 9 2019, 5:47 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/351/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/351/console

vlorentz updated this revision to Diff 4481.Apr 9 2019, 6:06 PM

rebase

swh-public-ci added a comment.Apr 9 2019, 6:14 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/356/ for more details.

Harbormaster completed remote builds in B5289: Diff 4481.Apr 9 2019, 6:14 PM
Closed by commit rDSTOcf99702f18fc: Use the db_transaction decorator on all _add() methods. (authored by vlorentz). · Explain WhyApr 9 2019, 6:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
swh/
storage/
183 lines

Diff 4482

View Options

swh/storage/storage.py

Loading...
About · Developer information · Legal