Fix person name clashes in revision_add and release_add.
ClosedPublic
Actions

Authored by vlorentz on Apr 9 2019, 4:24 PM.

Details

Reviewers

olasd

Group Reviewers

Reviewers

Commits

rDSTOCcd0d309850f0: Fix person name clashes in revision_add and release_add.
rDSTOcd0d309850f0: Fix person name clashes in revision_add and release_add.

Summary

When two revisions/releases have authors with the same fullname
but different names (which should never happen in practice, but
since name/email parsing is on a best-effort basis, you never
know...).

Bug found by Hypothesis.

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Apr 9 2019, 4:24 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 9 2019, 4:24 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/329/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/329/console

Harbormaster failed remote builds in B5239: Diff 4431!Apr 9 2019, 4:37 PM

vlorentz added a child revision: D1380: Rewrite skipped_content_missing to not use a temporary table..Apr 9 2019, 4:37 PM

vlorentz added a child revision: D1383: Add a test that adds arbitrary objects to the storage..Apr 9 2019, 4:44 PM

Sometimes, I wonder if we wouldn't be better off dropping the name and email parsed fields and only keeping fullname in the database...

In any case, the test would be less surprising if both authors were "sensible" parsings of the same fullname.

For instance, fullname = 'John Doe <john.doe@example.com>' (two spaces) can sensibly parse to name = 'John Doe', email = 'john.doe@example.com', as well as name = 'John Doe ', email = 'john.doe@example.com' (with the trailing space).

This revision is now accepted and ready to land.Apr 9 2019, 4:49 PM

vlorentz added a parent revision: D1382: Fix order of results of person_get..Apr 9 2019, 5:01 PM

less surprising test

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/338/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/338/console

Harbormaster failed remote builds in B5250: Diff 4442!Apr 9 2019, 5:22 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/350/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/350/console