Page MenuHomeSoftware Heritage
Differential D1256

api/server: fallback to application/json as best mimetype for content nego
ClosedPublic
Actions

Authored by douardda on Mar 18 2019, 10:53 AM.

Details

Reviewers
ardumont
olasd
Group Reviewers
Reviewers
Commits
rDCORE45387b7f809e: api/server: fallback to application/json as best mimetype for content nego
Summary

we almost never return text/plain or text/html, so json is a better default
value.

Diff Detail

Repository
rDCORE Foundations and core functionalities
Branch
master
Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 4683
Build 6228: tox-on-jenkinsJenkins
Build 6227: arc lint + arc unit

Event Timeline

douardda created this revision.Mar 18 2019, 10:53 AM
Herald added a reviewer: Reviewers. · View Herald TranscriptMar 18 2019, 10:53 AM
Harbormaster failed remote builds in B4683: Diff 3966!Mar 18 2019, 10:56 AM
swh-public-ci added a subscriber: swh-public-ci.Mar 18 2019, 10:56 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCORE/job/tox/182/
See console output for more information: https://jenkins.softwareheritage.org/job/DCORE/job/tox/182/console

vlorentz added a subscriber: vlorentz.Mar 18 2019, 12:27 PM

Shouldn't msgpack be preferred over json?

ardumont added a subscriber: ardumont.Mar 18 2019, 12:35 PM

Shouldn't msgpack be preferred over json?

Not if you want to read the data from the cli for example (without the hassle of adding extra flags ;)

ardumont accepted this revision.Mar 18 2019, 12:35 PM
This revision is now accepted and ready to land.Mar 18 2019, 12:35 PM
olasd accepted this revision.Mar 18 2019, 1:48 PM
olasd added a subscriber: olasd.
In D1256#26772, @ardumont wrote:

Shouldn't msgpack be preferred over json?

Not if you want to read the data from the cli for example (without the hassle of adding extra flags ;)

Is there really anything/anyone trying to read data from the backend RPC servers on the CLI?

Closed by commit rDCORE45387b7f809e: api/server: fallback to application/json as best mimetype for content nego (authored by douardda). · Explain WhyMar 18 2019, 1:51 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
swh/
core/
api/
2 lines

Diff 3966

View Options

swh/core/api/__init__.py

Loading...
About · Developer information · Legal