swh-web: Unify production and development start up
ClosedPublic
Actions

Authored by ardumont on Feb 23 2019, 1:57 AM.

Details

Reviewers

anlambert
douardda
vlorentz

Group Reviewers

Reviewers

Commits

rDENV8bec6a01cdb0: indexer-storage: Remove expose 5002 instruction
rDENVe5dc74ec4e47: docker-compose: Remove unused command
rDENVa8429eba9a10: swh-web: Unify production and development start up
rCDFDe5dc74ec4e47: docker-compose: Remove unused command
rCDFDa8429eba9a10: swh-web: Unify production and development start up
rCDFD8bec6a01cdb0: indexer-storage: Remove expose 5002 instruction

Summary

docker-compose: swh-web: Remove unused command (?)

Related T1533
Depends on D1182

Also:

indexer-storage: Remove expose 5002 instruction

Test Plan

SWH_SERVICE=swh-web; doco build $SWH_SERVICE; doco up -d $SWH_SERVICE; doco logs --follow $SWH_SERVICE

Diff Detail

Repository

rCDFD Dockerfiles for developers

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Feb 23 2019, 1:57 AM

Harbormaster completed remote builds in B4417: Diff 3726.Feb 23 2019, 1:57 AM

vlorentz accepted this revision.Feb 25 2019, 10:42 AM

This revision is now accepted and ready to land.Feb 25 2019, 10:42 AM

anlambert added inline comments.Feb 25 2019, 11:30 AM

dockerfiles/swh-web/entrypoint.sh
23 ↗	(On Diff #3726)	gunicorn will not serve static assets to clients so a nginx or apache2 setup should be put in place to do so.

ardumont marked an inline comment as done.Feb 25 2019, 11:31 AM

ardumont added inline comments.

dockerfiles/swh-web/entrypoint.sh
23 ↗	(On Diff #3726)	oh right! There is some nginx setup already in the repository so that might be address using that.

ardumont marked an inline comment as done.Feb 25 2019, 11:32 AM

ardumont added inline comments.

dockerfiles/swh-web/entrypoint.sh
23 ↗	(On Diff #3726)	addressed*

I'll address the next step (serve static files with nginx) later though.

Closed by commit rCDFD8bec6a01cdb0: indexer-storage: Remove expose 5002 instruction (authored by ardumont). · Explain WhyFeb 25 2019, 12:13 PM

This revision was automatically updated to reflect the committed changes.

ardumont mentioned this in T1542: docker-dev: swh-web: Service static asset with nginx.Feb 25 2019, 12:14 PM

ardumont added a commit: rDENV8bec6a01cdb0: indexer-storage: Remove expose 5002 instruction.Nov 26 2019, 1:35 PM

ardumont added a commit: rDENVa8429eba9a10: swh-web: Unify production and development start up.

ardumont added a commit: rDENVe5dc74ec4e47: docker-compose: Remove unused command.

Revision Contents
Changeset List

Path

Size

dockerfiles/

swh-indexer-storage/

Dockerfile

2 lines

Diff 3736

View Options

dockerfiles/swh-indexer-storage/Dockerfile

swh-web: Unify production and development start upClosedPublicActions