Details

Reviewers

olasd

Group Reviewers

Reviewers

Commits

rDSCH099effd6f61f: Start writing tests for the CLI.

Diff Detail

Repository

rDSCH Scheduling utilities

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Feb 21 2019, 3:08 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 21 2019, 3:08 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSCH/job/tox/190/
See console output for more information: https://jenkins.softwareheritage.org/job/DSCH/job/tox/190/console

Harbormaster failed remote builds in B4384: Diff 3699!Feb 21 2019, 3:10 PM

Fix pytest collection.

Fix celery test issue with import order.

Build was aborted

Link to build: https://jenkins.softwareheritage.org/job/DSCH/job/tox/192/
See console output for more information: https://jenkins.softwareheritage.org/job/DSCH/job/tox/192/console

Harbormaster failed remote builds in B4385: Diff 3700!Feb 22 2019, 9:51 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSCH/job/tox/193/
See console output for more information: https://jenkins.softwareheritage.org/job/DSCH/job/tox/193/console

Harbormaster failed remote builds in B4386: Diff 3701!Feb 22 2019, 9:58 AM

rebuild

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSCH/job/tox/194/
See console output for more information: https://jenkins.softwareheritage.org/job/DSCH/job/tox/194/console

Harbormaster failed remote builds in B4396: Diff 3711!Feb 22 2019, 10:54 AM

Fix timezone.

Build is green
See https://jenkins.softwareheritage.org/job/DSCH/job/tox/195/ for more details.

Harbormaster completed remote builds in B4405: Diff 3719.Feb 22 2019, 11:07 AM

Add tests for list_pending_tasks.

Build is green
See https://jenkins.softwareheritage.org/job/DSCH/job/tox/196/ for more details.

Harbormaster completed remote builds in B4410: Diff 3723.Feb 22 2019, 3:31 PM

vlorentz added a child revision: D1194: Move option parsing to its own (tested) function..Feb 26 2019, 2:09 PM

Thanks for this, looks like a good starting point.

I think I'd wrap the regular expressions' first line with a backslash to look like this:

    expected = r'''\
\[INFO\] swh.core.config -- Loading config file .*
Found 1 swh-test-ping tasks

[...]
'''

So that the full text can be more easily copy/pasted.

We can also probably use re.fullmatch to drop the need for the start anchor (I think?)

swh/scheduler/cli.py
105	Should probably be updated to say "none set" or something
swh/scheduler/tests/test_cli.py
24–35	Please add a comment to document why we need to jump these hoops. I think I understand it but better be explicit :)

This revision now requires changes to proceed.Feb 27 2019, 12:02 PM

In D1173#25465, @olasd wrote:
I think I'd wrap the regular expressions' first line with a backslash to look like this:
    expected = r'''\
\[INFO\] swh.core.config -- Loading config file .*
Found 1 swh-test-ping tasks

[...]
'''
So that the full text can be more easily copy/pasted.

I tried, it doesn't work.

>>> foo = r'''\
... foo'''
>>> print(foo)
\
foo

We can also probably use re.fullmatch to drop the need for the start anchor (I think?)

TIL

In D1173#25470, @vlorentz wrote:
In D1173#25465, @olasd wrote:
I think I'd wrap the regular expressions' first line with a backslash to look like this:
    expected = r'''\
\[INFO\] swh.core.config -- Loading config file .*
Found 1 swh-test-ping tasks

[...]
'''
So that the full text can be more easily copy/pasted.
I tried, it doesn't work.
>>> foo = r'''\
... foo'''
>>> print(foo)
\
foo