Page MenuHomeSoftware Heritage
Differential D1195

Add support for non-string options when scheduling tasks.
ClosedPublic
Actions

Authored by vlorentz on Feb 26 2019, 2:09 PM.

Details

Reviewers
olasd
Group Reviewers
Reviewers
Maniphest Tasks
T1536: Add a CLI tool to run a task on all origins
Commits
rDSCHda290c207c3e: Add support for non-string options when scheduling tasks.
Summary

This also fixes the pretty-printing of tasks, which was ambiguous
(42 and "42" where both printed as 42).

Depends on D1194

Needed to scheduling indexer tasks (which take a boolean argument parse_ids).

Diff Detail

Repository
rDSCH Scheduling utilities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Feb 26 2019, 2:09 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 26 2019, 2:09 PM
Harbormaster failed remote builds in B4452: Diff 3760!Feb 26 2019, 2:09 PM
swh-public-ci added a subscriber: swh-public-ci.Feb 26 2019, 2:09 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSCH/job/tox/204/
See console output for more information: https://jenkins.softwareheritage.org/job/DSCH/job/tox/204/console

vlorentz edited the summary of this revision. (Show Details)Feb 26 2019, 2:13 PM
vlorentz added a task: T1536: Add a CLI tool to run a task on all origins.
vlorentz edited the summary of this revision. (Show Details)
vlorentz edited the summary of this revision. (Show Details)
vlorentz added a child revision: D1196: Add an 'swh-scheduler task schedule_origins' command to run a task on all origins..Feb 26 2019, 2:21 PM
vlorentz updated this revision to Diff 3783.Feb 27 2019, 4:53 PM
  • rebase
Harbormaster failed remote builds in B4477: Diff 3783!Feb 27 2019, 4:54 PM
swh-public-ci added a comment.Feb 27 2019, 4:54 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSCH/job/tox/210/
See console output for more information: https://jenkins.softwareheritage.org/job/DSCH/job/tox/210/console

olasd added a subscriber: olasd.Mar 1 2019, 11:08 AM

I don't like the idea of making double quoting mandatory on a command-line tool very much.

Can we add a fallback to parsing the input as a plain string if ast.literal_eval fails? (I guess that'd be a YAML-ish parsing fallback strategy :P)

vlorentz added a child revision: D1216: Add tests for 'swh-scheduler task list-pending' and 'swh-scheduler task list'..Mar 1 2019, 2:28 PM
olasd requested changes to this revision.Mar 5 2019, 8:40 AM
This revision now requires changes to proceed.Mar 5 2019, 8:40 AM
vlorentz added a comment.EditedMar 11 2019, 11:57 AM

Or I could just parse it directly as yaml, as it's (mostly?) a superset of what ast.literal_eval accepts. And it spares us a new quirky format.

olasd added a comment.Mar 11 2019, 12:28 PM
In D1195#26144, @vlorentz wrote:

Or I could just parse it directly as yaml, as it's (mostly?) a superset of what ast.literal_eval accepts. And it spares us a new quirky format.

My first reaction is *yuck* but I guess that'd work...

vlorentz updated this revision to Diff 3881.Mar 11 2019, 1:55 PM
  • rebase
  • use yaml instead of ast.literal_eval
vlorentz edited the summary of this revision. (Show Details)Mar 11 2019, 1:56 PM
swh-public-ci added a comment.Mar 11 2019, 2:01 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSCH/job/tox/220/ for more details.

Harbormaster completed remote builds in B4587: Diff 3881.Mar 11 2019, 2:01 PM
olasd accepted this revision.Mar 11 2019, 3:34 PM
olasd added inline comments.
swh/scheduler/cli_utils.py
46

It'd be nice(r) to know which argument was invalid.

swh/scheduler/tests/test_cli.py
115

That hunk shouldn't be needed?

This revision is now accepted and ready to land.Mar 11 2019, 3:34 PM
vlorentz updated this revision to Diff 3898.Mar 13 2019, 9:57 AM
  • Show which argument is invalid
Closed by commit rDSCHda290c207c3e: Add support for non-string options when scheduling tasks. (authored by vlorentz). · Explain WhyMar 13 2019, 9:57 AM
This revision was automatically updated to reflect the committed changes.
Harbormaster failed remote builds in B4613: Diff 3898!Mar 13 2019, 9:58 AM
swh-public-ci added a comment.Mar 13 2019, 9:58 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSCH/job/tox/223/
See console output for more information: https://jenkins.softwareheritage.org/job/DSCH/job/tox/223/console

Revision Contents
Changeset List

PathSize
1 line
swh/
scheduler/
26 lines
34 lines
tests/
18 lines

Diff 3899

View Options

requirements.txt

Loading...
View Options

swh/scheduler/cli.py

Loading...
View Options

swh/scheduler/cli_utils.py

Loading...
View Options

swh/scheduler/tests/test_cli.py

Loading...
About · Developer information · Legal