This increases coverage of the swh.core repository by:
- initializing db tests
- introducing hypothesis
- refactoring a bit the connection initialization of the basedb module
Details
Details
- Reviewers
anlambert - Group Reviewers
Reviewers - Maniphest Tasks
- T1411: reach a minimum of 80% SLOC coverage across all components
- Commits
- rDCOREc80a4afffdeb: Add test for BaseDb.connect.
rDCORE021746d08212: Add tests for swh.core.db.
Diff Detail
Diff Detail
- Repository
- rDCORE Foundations and core functionalities
- Branch
- test-db
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 4141 Build 5456: tox-on-jenkins Jenkins Build 5455: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/153/ for more details.
| requirements-test.txt | ||
|---|---|---|
| 3 | Even without regexps? | |
| requirements-test.txt | ||
|---|---|---|
| 3 | well, it works! I added it to the scheduler (matching the one we already have on indexer) and nothing complained. [1] is proof as it built (we can see debian tags and everything) [1] https://forge.softwareheritage.org/rDSCH3488c265f4e3f70c8591dd1c7064388b312e9144 | |
| 3 | no parenthesis though, don't know why i put that there. | |
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/175/ for more details.
Comment Actions
Looks good to me!
| swh/core/tests/test_db.py | ||
|---|---|---|
| 60 | Just a nitpick, I would put the strategy implementation into a dedicated function and named it according to your desired test inputs instead. | |
| swh/core/db/__init__.py | ||
|---|---|---|
| 111 | I'm unsure of that factorisation (because i'm not so sure of the workflow around those calls: from_pool, connect). Reading swh.storage.{storage,db} and scheduler's, the initialization sounds fine with this change but still... | |
Comment Actions
Not sure about the initialization refactoring and its impacts on the other modules.
Other than that, the rest sounds quite fine, thanks.
| swh/core/db/__init__.py | ||
|---|---|---|
| 111 | That will only be an issue when a connection object is created directly, instead of using one of these classmethods. grep "psycopg2\.conn" ../*/swh/ -r shows only two results outside swh.core: the vault (before D1108) and the swh.journal.checker. Neither use BaseDb.
Which ones? | |
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/176/ for more details.
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/177/ for more details.