Page MenuHomeSoftware Heritage
Differential D1017

Add a simple merge_configs function in config.py
ClosedPublic
Actions

Authored by douardda on Jan 28 2019, 5:29 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDCOREedfd0b3324e5: Add a simple merge_configs function in config.py
Summary

that recursively merge 2 (config) dictionaries.
This is meant to be used to simplify a bit the config system of several
systems of the swh platform (related to T1410 and T826).

depends on D1016

Diff Detail

Event Timeline

douardda created this revision.Jan 28 2019, 5:29 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJan 28 2019, 5:29 PM
Harbormaster failed remote builds in B3765: Diff 3223!Jan 28 2019, 5:30 PM
swh-public-ci added a subscriber: swh-public-ci.Jan 28 2019, 5:30 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCORE/job/tox/127/
See console output for more information: https://jenkins.softwareheritage.org/job/DCORE/job/tox/127/console

ardumont accepted this revision.Jan 29 2019, 10:07 AM
ardumont added a subscriber: ardumont.
ardumont added inline comments.
swh/core/config.py
226

shouldn't it be ...

...
    'key2': value3,
    'key3': value6,
}

I suppose there is an issue with the input instead and the key3 of the second dict should have been key2 instead?

This revision is now accepted and ready to land.Jan 29 2019, 10:07 AM
douardda marked an inline comment as done.Jan 29 2019, 10:33 AM
douardda added inline comments.
swh/core/config.py
226

indeed, good catch

vlorentz added a subscriber: vlorentz.Jan 29 2019, 10:34 AM
vlorentz added inline comments.
swh/core/config.py
226

This could be a doctest

douardda updated this revision to Diff 3235.Jan 29 2019, 10:35 AM

fix an error in the docstring

Closed by commit rDCOREedfd0b3324e5: Add a simple merge_configs function in config.py (authored by douardda). · Explain WhyJan 29 2019, 10:36 AM
This revision was automatically updated to reflect the committed changes.
Harbormaster failed remote builds in B3780: Diff 3235!Jan 29 2019, 10:36 AM
swh-public-ci added a comment.Jan 29 2019, 10:36 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCORE/job/tox/128/
See console output for more information: https://jenkins.softwareheritage.org/job/DCORE/job/tox/128/console

Revision Contents
Changeset List

PathSize
swh/
core/
72 lines
tests/
87 lines

Diff 3223

View Options

swh/core/config.py

Loading...
View Options

swh/core/tests/test_config.py

Loading...
About · Developer information · Legal