Differential D1017

Add a simple merge_configs function in config.py
ClosedPublic
Actions

Authored by douardda on Jan 28 2019, 5:29 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDCOREedfd0b3324e5: Add a simple merge_configs function in config.py

Summary

that recursively merge 2 (config) dictionaries.
This is meant to be used to simplify a bit the config system of several
systems of the swh platform (related to T1410 and T826).

depends on D1016

Diff Detail

Repository

rDCORE Foundations and core functionalities

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Jan 28 2019, 5:29 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 28 2019, 5:29 PM

Harbormaster failed remote builds in B3765: Diff 3223!Jan 28 2019, 5:30 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCORE/job/tox/127/
See console output for more information: https://jenkins.softwareheritage.org/job/DCORE/job/tox/127/console

ardumont accepted this revision.Jan 29 2019, 10:07 AM

ardumont added a subscriber: ardumont.

ardumont added inline comments.

swh/core/config.py
225	shouldn't it be ... ... 'key2': value3, 'key3': value6, } I suppose there is an issue with the input instead and the key3 of the second dict should have been key2 instead?