Page MenuHomeSoftware Heritage
Feed Advanced Search

Oct 12 2022

anlambert committed rDLDBASEa13e3e6f35bc: cpan: Align loader implementation with latest lister improvements (authored by anlambert).
cpan: Align loader implementation with latest lister improvements
Oct 12 2022, 11:38 AM
anlambert closed D8650: cpan: Remove module description from release message.
Oct 12 2022, 11:38 AM
anlambert committed rDLDBASEe17ee9e08e84: cpan: Remove module description from release message (authored by anlambert).
cpan: Remove module description from release message
Oct 12 2022, 11:38 AM
anlambert closed D8661: tarball: fallback using tar command when shutil.unpack_archive failed.
Oct 12 2022, 11:34 AM
anlambert committed rDCORE6a5ad7618587: tarball: fallback using tar command when shutil.unpack_archive failed (authored by anlambert).
tarball: fallback using tar command when shutil.unpack_archive failed
Oct 12 2022, 11:34 AM
anlambert updated the diff for D8661: tarball: fallback using tar command when shutil.unpack_archive failed.

Rebase

Oct 12 2022, 11:30 AM
anlambert closed D8660: tarball: Fix also directory permissions in normalize_permissions.
Oct 12 2022, 11:30 AM
anlambert committed rDCORE6012be54994c: tarball: Fix also directory permissions in normalize_permissions (authored by anlambert).
tarball: Fix also directory permissions in normalize_permissions
Oct 12 2022, 11:30 AM
anlambert updated the diff for D8660: tarball: Fix also directory permissions in normalize_permissions.

Address @vlorentz comment

Oct 12 2022, 11:26 AM
anlambert updated the diff for D8661: tarball: fallback using tar command when shutil.unpack_archive failed.

Improve test

Oct 12 2022, 11:24 AM
anlambert added a comment to D8661: tarball: fallback using tar command when shutil.unpack_archive failed.

Here is how to reproduce the test without the 25KB tarball:

>>> import io
>>> import tarfile
>>> tf = tarfile.open("repro.tar.gz", "w:gz")
>>> ti = tarfile.TarInfo("dir")
>>> ti.mode = 0o777
>>> tf.addfile(ti)
>>> ti = tarfile.TarInfo("dir/file")
>>> tf.addfile(ti, io.BytesIO(b"hello world"))
>>> tf.close()

>>> from swh.core import tarball
>>> tarball.uncompress("repro.tar.gz", "/tmp/foo2")
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/dev/swh-environment/swh-core/swh/core/tarball.py", line 161, in uncompress
    shutil.unpack_archive(tarpath, extract_dir=dest, format=format)
  File "/usr/lib/python3.9/shutil.py", line 1236, in unpack_archive
    func(filename, extract_dir, **dict(format_info[2]))
  File "/usr/lib/python3.9/shutil.py", line 1178, in _unpack_tarfile
    tarobj.extractall(extract_dir)
  File "/usr/lib/python3.9/tarfile.py", line 2036, in extractall
    self.extract(tarinfo, path, set_attrs=not tarinfo.isdir(),
  File "/usr/lib/python3.9/tarfile.py", line 2077, in extract
    self._extract_member(tarinfo, os.path.join(path, tarinfo.name),
  File "/usr/lib/python3.9/tarfile.py", line 2150, in _extract_member
    self.makefile(tarinfo, targetpath)
  File "/usr/lib/python3.9/tarfile.py", line 2191, in makefile
    with bltn_open(targetpath, "wb") as target:
NotADirectoryError: [Errno 20] Not a directory: '/tmp/foo2/dir/file'

(though we should probably commit the repro.tar.gz file this generates, in case tarfile becomes smarter in future Python versions and prevents generating tarballs like this)

Oct 12 2022, 11:20 AM

Oct 11 2022

anlambert requested review of D8661: tarball: fallback using tar command when shutil.unpack_archive failed.
Oct 11 2022, 6:07 PM
anlambert added a revision to T2833: cpan.loader - archive Perl modules from CPAN: D8661: tarball: fallback using tar command when shutil.unpack_archive failed.
Oct 11 2022, 6:05 PM · CPAN lister, Archive coverage
anlambert updated the summary of D8660: tarball: Fix also directory permissions in normalize_permissions.
Oct 11 2022, 5:44 PM
anlambert requested review of D8660: tarball: Fix also directory permissions in normalize_permissions.
Oct 11 2022, 5:16 PM
anlambert closed D8648: cpan: Fix module version extraction for some edge cases.
Oct 11 2022, 5:16 PM
anlambert committed rDLS05cd1de1cde7: cpan: Fix module version extraction for some edge cases (authored by anlambert).
cpan: Fix module version extraction for some edge cases
Oct 11 2022, 5:15 PM
anlambert closed D8615: cpan: Improve listing process by querying the metacpan release endpoint.
Oct 11 2022, 5:15 PM
anlambert committed rDLSf57b8f3a2c49: cpan: Improve listing process by querying the metacpan release endpoint (authored by anlambert).
cpan: Improve listing process by querying the metacpan release endpoint
Oct 11 2022, 5:15 PM
anlambert requested review of D8652: cpan: Collect extrinsic metadata for each module release.
Oct 11 2022, 4:03 PM
anlambert updated the diff for D8648: cpan: Fix module version extraction for some edge cases.

rebase

Oct 11 2022, 3:25 PM
anlambert updated the diff for D8615: cpan: Improve listing process by querying the metacpan release endpoint.

remove no longer needed variable

Oct 11 2022, 3:25 PM
anlambert updated the diff for D8648: cpan: Fix module version extraction for some edge cases.

rebase

Oct 11 2022, 3:21 PM
anlambert updated the diff for D8615: cpan: Improve listing process by querying the metacpan release endpoint.

really fix docstring

Oct 11 2022, 3:14 PM
anlambert updated the diff for D8648: cpan: Fix module version extraction for some edge cases.

Rebase

Oct 11 2022, 3:03 PM
anlambert updated the diff for D8615: cpan: Improve listing process by querying the metacpan release endpoint.

Fix docstring

Oct 11 2022, 3:02 PM
anlambert updated the diff for D8651: cpan: Do not parse intrinsic metadata for getting module author.

Rebase

Oct 11 2022, 2:39 PM
anlambert updated the diff for D8616: cpan: Align loader implementation with latest lister improvements.

Rebase and synchronize again with latest cpan lister changes

Oct 11 2022, 2:39 PM
anlambert updated the diff for D8650: cpan: Remove module description from release message.

Rebase

Oct 11 2022, 2:38 PM
anlambert updated the diff for D8648: cpan: Fix module version extraction for some edge cases.

Rebase

Oct 11 2022, 2:18 PM
anlambert updated the diff for D8615: cpan: Improve listing process by querying the metacpan release endpoint.

Update: Address @vlorentz comments

Oct 11 2022, 2:17 PM
anlambert added inline comments to D8615: cpan: Improve listing process by querying the metacpan release endpoint.
Oct 11 2022, 12:11 PM
anlambert abandoned D8649: cpan: Use a fake origin URL instead of an HTTP one.

Why is it an issue that it doesn't point anywhere? The https:// URL will at least work for most packages, while cpan:// won't work for any package, so it's less usable in practice. And it removes the option of adding other instances.

Plus, we shouldn't invent new schemes like this; they may conflict with new standards (even if we already do it for Debian)

Oct 11 2022, 11:55 AM
anlambert added a comment to D8651: cpan: Do not parse intrinsic metadata for getting module author.

How come this doesn't affect tests?

Oct 11 2022, 11:46 AM

Oct 10 2022

anlambert requested review of D8651: cpan: Do not parse intrinsic metadata for getting module author.
Oct 10 2022, 5:08 PM
anlambert updated the summary of D8649: cpan: Use a fake origin URL instead of an HTTP one.
Oct 10 2022, 5:05 PM
anlambert updated the summary of D8649: cpan: Use a fake origin URL instead of an HTTP one.
Oct 10 2022, 5:05 PM
anlambert updated the summary of D8649: cpan: Use a fake origin URL instead of an HTTP one.
Oct 10 2022, 5:05 PM
anlambert added a revision to T2833: cpan.loader - archive Perl modules from CPAN: D8652: cpan: Collect extrinsic metadata for each module release.
Oct 10 2022, 5:04 PM · CPAN lister, Archive coverage
anlambert added a revision to T2833: cpan.loader - archive Perl modules from CPAN: D8651: cpan: Do not parse intrinsic metadata for getting module author.
Oct 10 2022, 5:04 PM · CPAN lister, Archive coverage
anlambert requested review of D8650: cpan: Remove module description from release message.
Oct 10 2022, 5:03 PM
anlambert updated the diff for D8616: cpan: Align loader implementation with latest lister improvements.

Rebase and move description removal from release message in separate commit and diff

Oct 10 2022, 5:03 PM
anlambert updated the summary of D8615: cpan: Improve listing process by querying the metacpan release endpoint.
Oct 10 2022, 5:01 PM
anlambert updated the summary of D8616: cpan: Align loader implementation with latest lister improvements.
Oct 10 2022, 5:00 PM
anlambert requested review of D8649: cpan: Use a fake origin URL instead of an HTTP one.
Oct 10 2022, 4:37 PM
anlambert requested review of D8648: cpan: Fix module version extraction for some edge cases.
Oct 10 2022, 4:32 PM
anlambert added a revision to T2833: cpan.loader - archive Perl modules from CPAN: D8649: cpan: Use a fake origin URL instead of an HTTP one.
Oct 10 2022, 4:32 PM · CPAN lister, Archive coverage
anlambert added a revision to T2833: cpan.loader - archive Perl modules from CPAN: D8648: cpan: Fix module version extraction for some edge cases.
Oct 10 2022, 4:26 PM · CPAN lister, Archive coverage
anlambert updated the diff for D8615: cpan: Improve listing process by querying the metacpan release endpoint.

Rebase and update cpan lister:

Oct 10 2022, 4:25 PM
anlambert closed D8646: base-buster/Dockerfile: Ensure to add nix binaries location in PATH.
Oct 10 2022, 2:35 PM
anlambert committed rCDFJc4c67c17cecb: base-buster/Dockerfile: Ensure to add nix binaries location in PATH (authored by anlambert).
base-buster/Dockerfile: Ensure to add nix binaries location in PATH
Oct 10 2022, 2:35 PM
anlambert accepted D8647: Require Rust-free versions of Breezy.

For the record, we can install rust this way on buster but I agree it is better pinning breezy.

Oct 10 2022, 2:34 PM
anlambert requested review of D8646: base-buster/Dockerfile: Ensure to add nix binaries location in PATH.
Oct 10 2022, 2:12 PM
anlambert committed rCDFJc22c4f22b385: base-buster/Dockerfile: Ensure to add nix binaries location in PATH (authored by anlambert).
base-buster/Dockerfile: Ensure to add nix binaries location in PATH
Oct 10 2022, 1:54 PM
anlambert added inline comments to D8640: Pubdev: Do not rely on intrinsic metadata.
Oct 10 2022, 1:26 PM
anlambert accepted D8171: crates: Loader implements incremental mode.

Looks good to me, thanks !

Oct 10 2022, 1:20 PM
anlambert closed D8644: query_language/tokens: Add new origin visit types.
Oct 10 2022, 1:11 PM
anlambert committed rDSEA4525db11eeea: query_language/tokens: Add new origin visit types (authored by anlambert).
query_language/tokens: Add new origin visit types
Oct 10 2022, 1:11 PM
anlambert requested review of D8644: query_language/tokens: Add new origin visit types.
Oct 10 2022, 12:16 PM

Oct 7 2022

anlambert accepted D8636: ContentLoader: Allow nar computation checks.
Oct 7 2022, 6:41 PM
anlambert accepted D8642: Change download.apache.org to https://dlcdn.apache.org.

Great, thanks !

Oct 7 2022, 5:26 PM
anlambert closed D8639: rubygems: Use gems database dump to improve listing output.
Oct 7 2022, 5:02 PM
anlambert committed rDLS108816f232d2: rubygems: Use gems database dump to improve listing output (authored by anlambert).
rubygems: Use gems database dump to improve listing output
Oct 7 2022, 5:02 PM
anlambert updated the diff for D8639: rubygems: Use gems database dump to improve listing output.

Update:

  • rebase
  • address @vlorentz comments
  • add extrinsic metadata URL for each gem version in the metadata sent along artifacts to rubygems loader
Oct 7 2022, 4:56 PM
anlambert added inline comments to D8639: rubygems: Use gems database dump to improve listing output.
Oct 7 2022, 4:39 PM
anlambert added inline comments to D8171: crates: Loader implements incremental mode.
Oct 7 2022, 4:03 PM
anlambert added inline comments to D8636: ContentLoader: Allow nar computation checks.
Oct 7 2022, 2:49 PM
anlambert accepted D8636: ContentLoader: Allow nar computation checks.

Looks good to me, I added a couple of nitpick comments.

Oct 7 2022, 1:53 PM
anlambert planned changes to D8616: cpan: Align loader implementation with latest lister improvements.
Oct 7 2022, 12:31 PM
anlambert planned changes to D8615: cpan: Improve listing process by querying the metacpan release endpoint.
Oct 7 2022, 12:30 PM
anlambert accepted D8638: npm: Fix crash on invalid URLs in 'bugs' field..
Oct 7 2022, 12:00 PM
anlambert requested review of D8639: rubygems: Use gems database dump to improve listing output.
Oct 7 2022, 12:00 PM
anlambert added a revision to T1777: Rubygems Lister: D8639: rubygems: Use gems database dump to improve listing output.
Oct 7 2022, 11:54 AM · RubyGems lister, Archive coverage

Oct 6 2022

anlambert added inline comments to D8171: crates: Loader implements incremental mode.
Oct 6 2022, 10:41 AM
anlambert accepted D8632: nixguix: Refactor by renaming success or failure the different datasets.
Oct 6 2022, 10:38 AM

Oct 5 2022

anlambert added inline comments to D8171: crates: Loader implements incremental mode.
Oct 5 2022, 5:03 PM
anlambert accepted D8454: Crates.io: Add last_update for each version of a crate.

LGTM, thanks !

Oct 5 2022, 4:52 PM
anlambert accepted D8631: nixguix: Deal with manifest entries without an integrity field.
Oct 5 2022, 4:36 PM
anlambert added inline comments to D8631: nixguix: Deal with manifest entries without an integrity field.
Oct 5 2022, 4:36 PM
anlambert added inline comments to D8631: nixguix: Deal with manifest entries without an integrity field.
Oct 5 2022, 4:19 PM
anlambert requested changes to D8454: Crates.io: Add last_update for each version of a crate.

Looks good to me, some minor changes to handle before I can accept it though.

Oct 5 2022, 3:53 PM
anlambert accepted D8630: {Cnt|Dir}Loader: Fix standard/nar hash mismatch behavior to fail loading.
Oct 5 2022, 3:13 PM
anlambert closed D8628: base-buster/Dockerfile: Use https scheme in all extra apt repositories.
Oct 5 2022, 1:34 PM
anlambert committed rCDFJceab3633a68a: base-buster/Dockerfile: Use https scheme in all extra apt repositories (authored by anlambert).
base-buster/Dockerfile: Use https scheme in all extra apt repositories
Oct 5 2022, 1:34 PM
anlambert requested review of D8628: base-buster/Dockerfile: Use https scheme in all extra apt repositories.
Oct 5 2022, 1:32 PM
anlambert accepted D8626: nixguix: Improve is_tarball detection pattern.
Oct 5 2022, 12:10 PM
anlambert closed D8627: base-buster/Dockerfile: Install nix binaries in buster image.
Oct 5 2022, 11:58 AM
anlambert committed rCDFJb7f329d73d65: base-buster/Dockerfile: Install nix binaries in buster image (authored by anlambert).
base-buster/Dockerfile: Install nix binaries in buster image
Oct 5 2022, 11:58 AM
anlambert closed D8625: docker: Install nix binaries in swh/stack image.
Oct 5 2022, 11:58 AM
anlambert committed rDENV8e164268c784: docker: Install nix binaries in swh/stack image (authored by anlambert).
docker: Install nix binaries in swh/stack image
Oct 5 2022, 11:58 AM
anlambert requested review of D8627: base-buster/Dockerfile: Install nix binaries in buster image.
Oct 5 2022, 11:56 AM
anlambert created P1480 (An Untitled Masterwork).
Oct 5 2022, 11:42 AM
anlambert requested review of D8625: docker: Install nix binaries in swh/stack image.
Oct 5 2022, 11:28 AM
anlambert closed D8622: docker/conf: Declare task queues for new nixguix lister and loaders.
Oct 5 2022, 11:24 AM
anlambert committed rDENV44a2bba3765f: docker/conf: Declare task queues for new nixguix lister and loaders (authored by anlambert).
docker/conf: Declare task queues for new nixguix lister and loaders
Oct 5 2022, 11:24 AM
anlambert accepted D8624: nixguix: Improve further tarball detection.
Oct 5 2022, 11:18 AM
anlambert accepted D8623: core.tarball: Add missing mimetype to the list.
Oct 5 2022, 11:16 AM
anlambert requested review of D8622: docker/conf: Declare task queues for new nixguix lister and loaders.
Oct 5 2022, 10:58 AM
anlambert added inline comments to D8619: nixguix: Improve tarball detection.
Oct 5 2022, 10:47 AM

Oct 4 2022

anlambert created P1478 (An Untitled Masterwork).
Oct 4 2022, 9:21 PM