- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Oct 12 2022
Rebase
Address @vlorentz comment
Improve test
In D8661#225558, @vlorentz wrote:Here is how to reproduce the test without the 25KB tarball:
>>> import io >>> import tarfile >>> tf = tarfile.open("repro.tar.gz", "w:gz") >>> ti = tarfile.TarInfo("dir") >>> ti.mode = 0o777 >>> tf.addfile(ti) >>> ti = tarfile.TarInfo("dir/file") >>> tf.addfile(ti, io.BytesIO(b"hello world")) >>> tf.close() >>> from swh.core import tarball >>> tarball.uncompress("repro.tar.gz", "/tmp/foo2") Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/home/dev/swh-environment/swh-core/swh/core/tarball.py", line 161, in uncompress shutil.unpack_archive(tarpath, extract_dir=dest, format=format) File "/usr/lib/python3.9/shutil.py", line 1236, in unpack_archive func(filename, extract_dir, **dict(format_info[2])) File "/usr/lib/python3.9/shutil.py", line 1178, in _unpack_tarfile tarobj.extractall(extract_dir) File "/usr/lib/python3.9/tarfile.py", line 2036, in extractall self.extract(tarinfo, path, set_attrs=not tarinfo.isdir(), File "/usr/lib/python3.9/tarfile.py", line 2077, in extract self._extract_member(tarinfo, os.path.join(path, tarinfo.name), File "/usr/lib/python3.9/tarfile.py", line 2150, in _extract_member self.makefile(tarinfo, targetpath) File "/usr/lib/python3.9/tarfile.py", line 2191, in makefile with bltn_open(targetpath, "wb") as target: NotADirectoryError: [Errno 20] Not a directory: '/tmp/foo2/dir/file'(though we should probably commit the repro.tar.gz file this generates, in case tarfile becomes smarter in future Python versions and prevents generating tarballs like this)
Oct 11 2022
rebase
remove no longer needed variable
rebase
really fix docstring
Rebase
Fix docstring
Rebase
Rebase and synchronize again with latest cpan lister changes
Rebase
Rebase
Update: Address @vlorentz comments
In D8649#225223, @vlorentz wrote:Why is it an issue that it doesn't point anywhere? The https:// URL will at least work for most packages, while cpan:// won't work for any package, so it's less usable in practice. And it removes the option of adding other instances.
Plus, we shouldn't invent new schemes like this; they may conflict with new standards (even if we already do it for Debian)
In D8651#225221, @vlorentz wrote:How come this doesn't affect tests?
Oct 10 2022
Rebase and move description removal from release message in separate commit and diff
Rebase and update cpan lister:
For the record, we can install rust this way on buster but I agree it is better pinning breezy.
Looks good to me, thanks !
Oct 7 2022
Great, thanks !
Update:
- rebase
- address @vlorentz comments
- add extrinsic metadata URL for each gem version in the metadata sent along artifacts to rubygems loader
Looks good to me, I added a couple of nitpick comments.
Oct 6 2022
Oct 5 2022
LGTM, thanks !
Looks good to me, some minor changes to handle before I can accept it though.