Rebase
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Feb 2 2022
Update from review comments
Feb 1 2022
Jan 27 2022
Fix docstring
Remove dead code
Jan 26 2022
Jan 25 2022
Add special case for revisions, compress with ZST
Jan 24 2022
database -> database to create
Expand command description
Jan 21 2022
Jan 20 2022
Jan 18 2022
Jan 17 2022
Rebase
Since D6676 the specialized methods of swh/graph/backend.py have all been removed and replaced by a generic proxy layer that calls all the methods in a completely transparent fashion, so this specific issue appears to be obsolete now.
I filed T3855 to document the architecture of the java code of swh-graph so that it stays on our radar.
I agree in general, but I disagree for the specifics of this diff. This is a description of the design of a specific component, which could be copied in an architecture presentation if it makes sense, but is certainly not an architecture presentation in itself.
SwhBidirectionalGraph: add UML diagram of class hierarchy
@vlorentz this is all written in the docstrings of the classes, which will be added to swh-docs once https://forge.softwareheritage.org/T1971 is implemented (which is going to be easier to do thanks to this diff :-))
Jan 15 2022
Jan 14 2022
Fix more buggy Graph -> SwhBidirectionalGraph
Remove Graph -> SwhBidirectionalGraph strings
Jan 13 2022
Here, I changed it so that all the paths go to the correct node.
Make random_walk tests deterministic
Jan 12 2022
Minor comment to avoid doing url parsing manually, otherwise LGTM
Jan 11 2022
I have just one security consideration, otherwise LGTM. Thanks!
Jan 10 2022
The coverage report does not seem to agree though ;)
No, we want to check that random_walk can reach its actual destination.
Jan 7 2022
I made a temporary fix in D6893, it doesn't solve the underlying issue but greatly decreases the probability of it happening. I'm not quite sure what would be a proper test for this endpoint, but this is at least enough to fix this issue in particular.
Jan 4 2022
Dec 14 2021
Dec 10 2021
Yes, this is implicitly all tested under the compression pipeline test.
Dec 6 2021
Dec 4 2021
Add simplify step, fix various review comments
Dec 1 2021
why the need for SortOutputHandler attributes to become final?
Nov 26 2021
Fix src/dst inversion, add regression test