Differential D2766

mimetype: Make the parsing more resilient
ClosedPublic
Actions

Authored by ardumont on Mar 4 2020, 4:08 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDCIDX54ac7407107a: mimetype: Make the parsing more resilient

Summary

The implementation chosen (try..except) is less clear than checking for the pattern.
But that error being not frequent., 2 times so far, I prefer avoidinging the string comparison.

Shout out if you disagree ;)

Test Plan

tox

Diff Detail

Repository

rDCIDX Metadata indexer

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 10934
Build 16450: tox-on-jenkins	Jenkins
Build 16449: arc lint + arc unit

Event Timeline

ardumont created this revision.Mar 4 2020, 4:08 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 4 2020, 4:08 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/716/ for more details.

Harbormaster completed remote builds in B10908: Diff 9843.Mar 4 2020, 4:10 PM

ardumont added inline comments.Mar 4 2020, 4:32 PM

swh/indexer/mimetype.py
31	encoding to None is not possible in the model so i choose empty. Same shout out if you disagree ;)

ardumont edited the summary of this revision. (Show Details)Mar 5 2020, 11:43 AM

vlorentz accepted this revision.Mar 5 2020, 2:36 PM

This revision is now accepted and ready to land.Mar 5 2020, 2:36 PM

Plug and rebase to latest master

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/717/ for more details.

Harbormaster completed remote builds in B10934: Diff 9866.Mar 5 2020, 3:46 PM

ardumont edited the summary of this revision. (Show Details)Mar 5 2020, 3:47 PM

Closed by commit rDCIDX54ac7407107a: mimetype: Make the parsing more resilient (authored by ardumont). · Explain WhyMar 5 2020, 3:47 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDCIDX54ac7407107a: mimetype: Make the parsing more resilient.

Revision Contents
Changeset List

Path

Size

swh/

indexer/

mimetype.py

5 lines

tests/

test_mimetype.py

27 lines

Diff 9866

View Options

swh/indexer/mimetype.py