Page MenuHomeSoftware Heritage
Differential D2646

Simplify method generation of _ArchiveData.
ClosedPublic
Actions

Authored by vlorentz on Feb 11 2020, 2:36 PM.

Details

Reviewers
anlambert
Group Reviewers
Reviewers
Commits
rDWAPPS4203381812b5: Simplify method generation of _ArchiveData.
Summary

Use a getattr like storage proxies do.

This will also be required when the validation proxy of swh-storage is merged,
as this proxy uses getattr, so inspect.getmembers() does not return all
method names that can be called.

Diff Detail

Event Timeline

vlorentz created this revision.Feb 11 2020, 2:36 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 11 2020, 2:36 PM
vlorentz updated this revision to Diff 9474.Feb 11 2020, 2:38 PM
vlorentz added a child revision: D2647: Use swh-storage validation proxy..

re-add comment

anlambert accepted this revision.Feb 11 2020, 2:41 PM
This revision is now accepted and ready to land.Feb 11 2020, 2:41 PM
Harbormaster failed remote builds in B10537: Diff 9474!Feb 11 2020, 2:42 PM
swh-public-ci added a comment.Feb 11 2020, 2:42 PM

Build was aborted

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/923/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/923/console

Harbormaster failed remote builds in B10535: Diff 9472!Feb 11 2020, 2:42 PM
swh-public-ci added a comment.Feb 11 2020, 2:42 PM

Build was aborted

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/531/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/531/console

swh-public-ci added a comment.Feb 11 2020, 2:52 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/925/ for more details.

swh-public-ci added a comment.Feb 11 2020, 3:00 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/533/ for more details.

This revision was landed with ongoing or failed builds.Feb 11 2020, 4:07 PM
Closed by commit rDWAPPS4203381812b5: Simplify method generation of _ArchiveData. (authored by vlorentz). · Explain Why
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDWAPPS4203381812b5: Simplify method generation of _ArchiveData..
vlorentz removed a child revision: D2647: Use swh-storage validation proxy..Feb 12 2020, 2:21 PM
vlorentz added a child revision: D2647: Use swh-storage validation proxy..Feb 12 2020, 2:21 PM

Revision Contents
Changeset List

PathSize
swh/
web/
tests/
18 lines

Diff 9472

View Options

swh/web/tests/conftest.py

Loading...
About · Developer information · Legal