Page MenuHomeSoftware Heritage

Add vault views.
ClosedPublic

Authored by seirl on Nov 7 2017, 6:30 PM.

Details

Reviewers
ardumont
anlambert
Group Reviewers
Reviewers
Summary
  • requirements.txt: fix yaml -> pyyaml
  • config: add allowed_hosts config option
  • api: add vault views

Diff Detail

Repository
rDWAPPS Web applications
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1083
Build 1425: Software Heritage Python tests
Build 1424: arc lint + arc unit

Event Timeline

  • requirements,control: add swh-vault
ardumont added a subscriber: ardumont.

Sounds good.

There are missing tests which will be added later in a future diff.

Quoting from seirl's swh-devel email:

I only did manual tests for now, i'm currently
adapting the unit tests I wrote for the old version. That'll come in a
future diff.

Note: as build fails, i've manually arc patch locally and tests are still good.

This revision is now accepted and ready to land.Nov 8 2017, 10:24 AM
anlambert added subscribers: zack, anlambert.

Looks good to me too.

Just one thing to discuss on, I am wondering if it is coherent to mount the vault feature under the api endpoint (current uri scheme is /api/1/vault/....).
Using simply /vault/.... and creating a dedicated Django application (like browse) could be another option.
@zack , what is your opinion on this ?

seirl requested review of this revision.Nov 10 2017, 1:18 PM
This revision is now accepted and ready to land.Nov 10 2017, 1:43 PM

Looks good to me. Nevertheless this needs a rebase as I pushed some new commits yersteday.