Page MenuHomeSoftware Heritage
Differential D2416

docker/compose: configure the statsd endpoint for most of the containers
ClosedPublic
Actions

Authored by douardda on Dec 9 2019, 4:26 PM.

Details

Reviewers
ardumont
anlambert
Group Reviewers
Reviewers
Commits
rDENV3007fb37f47d: docker/compose: configure the statsd endpoint for most of the containers
Summary

Depends on D2415.

Diff Detail

Repository
rDENV Development environment
Branch
current
Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 9630
Build 14182: arc lint + arc unit

Event Timeline

douardda created this revision.Dec 9 2019, 4:26 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptDec 9 2019, 4:26 PM
Harbormaster completed remote builds in B9618: Diff 8534.Dec 9 2019, 4:26 PM
douardda added a child revision: D2417: docker/compose: add rabbitmq_exporter service.Dec 9 2019, 4:26 PM
douardda updated this revision to Diff 8544.Dec 9 2019, 4:41 PM

rebase

Harbormaster completed remote builds in B9625: Diff 8544.Dec 9 2019, 4:41 PM
ardumont accepted this revision.Dec 9 2019, 4:41 PM
This revision is now accepted and ready to land.Dec 9 2019, 4:41 PM
anlambert accepted this revision.EditedDec 9 2019, 4:41 PM
anlambert added a subscriber: anlambert.

Great ! Could you also add that configuration to the swh-web service ? I am currently working on T2124 and I have added a couple of statsd metric to the webapp.

douardda added a comment.Dec 9 2019, 5:03 PM
In D2416#57093, @anlambert wrote:

Great ! Could you also add that configuration to the swh-web service ? I am currently working on T2124 and I have added a couple of statsd metric to the webapp.

Sure. I'm also moving these env vars in a dedicated file instead of putting them directly in the docker-compose file.

anlambert added a comment.Dec 9 2019, 5:05 PM

Sure. I'm also moving these env vars in a dedicated file instead of putting them directly in the docker-compose file.

+1

douardda updated this revision to Diff 8549.Dec 9 2019, 5:06 PM

move statsd emv var declarations in an env/statsd.env file and use it on swh-web

so anlambert is happy :-)

Harbormaster completed remote builds in B9630: Diff 8549.Dec 9 2019, 5:06 PM
Closed by commit rDENV3007fb37f47d: docker/compose: configure the statsd endpoint for most of the containers (authored by douardda). · Explain WhyDec 9 2019, 5:11 PM
This revision was automatically updated to reflect the committed changes.
douardda added a commit: rDENV3007fb37f47d: docker/compose: configure the statsd endpoint for most of the containers.

Revision Contents
Changeset List

PathSize
docker/
23 lines
env/
2 lines

Diff 8549

View Options

docker/docker-compose.yml

Loading...
View Options

docker/env/statsd.env

Loading...
About · Developer information · Legal