Differential D2299

BufferedLoader: proxy storages may return empty dict for add_xxx methods
ClosedPublic
Actions

Authored by douardda on Nov 18 2019, 4:37 PM.

Details

Reviewers

olasd

Group Reviewers

Reviewers

Commits

rDLDBASEcb42fea77070: BufferedLoader: proxy storages may return empty dict for add_xxx methods

Summary

so ensure the BufferedLoader class is aware of this.

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Branch

master

Lint

Lint Skipped

Unit

Unit Tests Skipped

Build Status

Buildable 9100
Build 13307: tox-on-jenkins	Jenkins
Build 13306: arc lint + arc unit

Event Timeline

douardda created this revision.Nov 18 2019, 4:37 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 18 2019, 4:37 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/231/ for more details.

Harbormaster completed remote builds in B9100: Diff 7907.Nov 18 2019, 4:39 PM

olasd accepted this revision.Nov 18 2019, 5:02 PM

This revision is now accepted and ready to land.Nov 18 2019, 5:02 PM

Closed by commit rDLDBASEcb42fea77070: BufferedLoader: proxy storages may return empty dict for add_xxx methods (authored by douardda). · Explain WhyNov 18 2019, 5:04 PM

This revision was automatically updated to reflect the committed changes.

douardda added a commit: rDLDBASEcb42fea77070: BufferedLoader: proxy storages may return empty dict for add_xxx methods.

ardumont mentioned this in T2094: KeyError: 'content:add' in swh.loader.core.loader.Nov 19 2019, 11:28 AM

Revision Contents
Changeset List

Path

Size

swh/

loader/

core/

loader.py

8 lines

Diff 7907

View Options

BufferedLoader: proxy storages may return empty dict for add_xxx methodsClosedPublicActions