Page MenuHomeSoftware Heritage

Added revision_metadata table and methods into storage
ClosedPublic

Authored by moranegg on Jul 27 2017, 3:37 PM.

Diff Detail

Repository
rDSTO Storage manager
Branch
metadata
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 972
Build 1289: Software Heritage Python tests
Build 1288: arc lint + arc unit

Event Timeline

Sounds fine :)

We should maybe try to avoid duplicating values in tests.
The file is big enough as it is...

sql/swh-func.sql
2110

indentation seems off here.

swh/storage/tests/test_storage.py
3233

As this is pretty long, maybe find a way to avoid duplication in those data (same goes for the next test)

For example:

'translated_metadata': metadata_rev['translated_metadata']
swh/storage/tests/test_storage.py
3233

... next test

i meant next tests :)

moranegg marked an inline comment as done.

Refactor tests to keep it short and simple

This revision is now accepted and ready to land.Jul 28 2017, 12:05 PM
This revision was automatically updated to reflect the committed changes.