Remove indirection swh.web.wsgi to start server
ClosedPublic
Actions

Authored by ardumont on Oct 10 2019, 12:04 PM.

Details

Reviewers

anlambert
vlorentz

Group Reviewers

Reviewers

Commits

rDWAPPSe06b7191d1ee: Remove indirection swh.web.wsgi to start server

Summary

As mentioned in the diff below, already tested both in docker,
staging, and production, everything is fine.

Related D2109
Related D2110

Test Plan

tox

Diff Detail

Repository

rDWAPPS Web applications

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 8281
Build 11960: Cypress tests for swh-web diffs	Jenkins
Build 11959: tox-on-jenkins	Jenkins
Build 11958: arc lint + arc unit

Event Timeline

ardumont created this revision.Oct 10 2019, 12:04 PM

There is also a reference to the wsgi module in Makefile.local

This revision now requires changes to proceed.Oct 10 2019, 12:07 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/730/ for more details.

Update missing wsgi reference

vlorentz accepted this revision.Oct 10 2019, 12:12 PM

anlambert requested changes to this revision.Oct 10 2019, 12:13 PM

anlambert added inline comments.

Makefile.local
62	I think `DJANGO_SETTINGS_MODULE` should be set before calling gunicorn here

This revision now requires changes to proceed.Oct 10 2019, 12:13 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/334/ for more details.

Harbormaster completed remote builds in B8277: Diff 7079.Oct 10 2019, 12:14 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/731/ for more details.

Set the DJANGO_SETTINGS_MODULE environment variable.

I'm not sure we want to integrate it in the makefile though ¯\_(ツ)_/¯

That could be to the users to determine what they want:

DJANGO_SETTINGS_MODULE=swh.web.settings.development make run-gunicorn-server

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/335/ for more details.

Harbormaster completed remote builds in B8281: Diff 7080.Oct 10 2019, 12:24 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/732/ for more details.

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/336/ for more details.

Harbormaster completed remote builds in B8283: Diff 7082.Oct 10 2019, 12:32 PM

I'm not sure we want to integrate it in the makefile though ¯\_(ツ)_/¯

That could be to the users to determine what they want:

This target is used to mimic production behavior so production settings should be set by default from my point of view (this was the previous behavior).

This revision is now accepted and ready to land.Oct 10 2019, 1:12 PM

This target is used to mimic production behavior so production settings should be set by default from my point of view (this was the previous behavior).

Yes, yes, that's why i made it back ;)

Closed by commit rDWAPPSe06b7191d1ee: Remove indirection swh.web.wsgi to start server (authored by ardumont). · Explain WhyOct 10 2019, 1:29 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDWAPPSe06b7191d1ee: Remove indirection swh.web.wsgi to start server.