Page MenuHomeSoftware Heritage

api servers: Unify the server starting point with production
ClosedPublic

Authored by ardumont on Oct 10 2019, 10:47 AM.

Diff Detail

Repository
rCDFD Dockerfiles for developers
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Oct 10 2019, 10:47 AM
ardumont retitled this revision from api server: Unify the server starting point with production to api servers: Unify the server starting point with production.Oct 10 2019, 11:05 AM
ardumont updated this revision to Diff 7075.Oct 10 2019, 11:17 AM
  • deposit: Remove indirections in deposit definitions
vlorentz requested changes to this revision.Oct 10 2019, 11:20 AM
vlorentz added inline comments.
docker-compose.yml
246–249 ↗(On Diff #7075)

why not in a .env file?

This revision now requires changes to proceed.Oct 10 2019, 11:20 AM
ardumont added inline comments.Oct 10 2019, 11:22 AM
docker-compose.yml
246–249 ↗(On Diff #7075)

It's:

  • clearer to read here without indirection
  • used only once
  • deposit is kinda the same as swh-web same (django apps) which does this as well
ardumont edited the summary of this revision. (Show Details)Oct 10 2019, 11:23 AM
ardumont edited the test plan for this revision. (Show Details)
vlorentz accepted this revision.Oct 10 2019, 11:23 AM
This revision is now accepted and ready to land.Oct 10 2019, 11:23 AM