Differential D2110

api servers: Unify the server starting point with production
ClosedPublic
Actions

Authored by ardumont on Oct 10 2019, 10:47 AM.

Tags

None

Subscribers

None

Details

Reviewers

anlambert
douardda
vlorentz

Group Reviewers

Commits

rDENVaaa57c19b57f: deposit: Remove indirections in deposit definitions
rDENV5dab53fee61f: api server: Unify the server starting point with production
rCDFDaaa57c19b57f: deposit: Remove indirections in deposit definitions
rCDFD5dab53fee61f: api server: Unify the server starting point with production

Summary

Related D2109

(Also add a bit of deposit definition cleanup)

Test Plan

doco up
check api services impacted (deposit, webapp, objstorage, storage, indexer-storage)

Diff Detail

Repository

rCDFD Dockerfiles for developers

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Oct 10 2019, 10:47 AM

Harbormaster completed remote builds in B8264: Diff 7070.Oct 10 2019, 10:47 AM

ardumont retitled this revision from api server: Unify the server starting point with production to api servers: Unify the server starting point with production.Oct 10 2019, 11:05 AM

deposit: Remove indirections in deposit definitions

Harbormaster completed remote builds in B8269: Diff 7075.Oct 10 2019, 11:17 AM

vlorentz requested changes to this revision.Oct 10 2019, 11:20 AM

vlorentz added inline comments.

docker-compose.yml
246–249 ↗	(On Diff #7075)	why not in a .env file?

This revision now requires changes to proceed.Oct 10 2019, 11:20 AM

ardumont added inline comments.Oct 10 2019, 11:22 AM

docker-compose.yml
246–249 ↗	(On Diff #7075)	It's: clearer to read here without indirection used only once deposit is kinda the same as swh-web same (django apps) which does this as well

ardumont edited the summary of this revision. (Show Details)Oct 10 2019, 11:23 AM

ardumont edited the test plan for this revision. (Show Details)

vlorentz accepted this revision.Oct 10 2019, 11:23 AM

This revision is now accepted and ready to land.Oct 10 2019, 11:23 AM

Closed by commit rCDFD5dab53fee61f: api server: Unify the server starting point with production (authored by ardumont). · Explain WhyOct 10 2019, 11:26 AM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rCDFD5dab53fee61f: api server: Unify the server starting point with production.

ardumont added a commit: rCDFDaaa57c19b57f: deposit: Remove indirections in deposit definitions.

ardumont mentioned this in rDOBJS49d56168d4e9: Remove indirection swh.objstorage.api.wsgi to start server.Oct 10 2019, 11:35 AM

ardumont mentioned this in rCDFD53235b7ee8ab: scheduler: Unify the server starting point with production.Oct 10 2019, 11:54 AM

ardumont mentioned this in rSPSITE9496453d1b7c: scheduler: Use directly the package's server module to start server.

ardumont mentioned this in D2112: Remove indirection swh.web.wsgi to start server.Oct 10 2019, 12:04 PM

ardumont mentioned this in rDSCH349d23ee50db: scheduler: Use directly the package's server module to start server.Oct 10 2019, 12:06 PM

ardumont mentioned this in rDWAPPSe06b7191d1ee: Remove indirection swh.web.wsgi to start server.Oct 10 2019, 1:29 PM

ardumont added a commit: rDENV5dab53fee61f: api server: Unify the server starting point with production.Nov 26 2019, 1:35 PM

ardumont added a commit: rDENVaaa57c19b57f: deposit: Remove indirections in deposit definitions.

ardumont mentioned this in rDENV53235b7ee8ab: scheduler: Unify the server starting point with production.

Revision Contents
Changeset List

Path

Size

services/

swh-deposit/

2 lines

swh-indexer-storage/

2 lines

swh-objstorage/

2 lines

swh-storage/

2 lines

swh-web/

2 lines

Diff 7076

services/swh-deposit/entrypoint.sh

Loading...

services/swh-indexer-storage/entrypoint.sh

Loading...

services/swh-objstorage/entrypoint.sh

Loading...

services/swh-storage/entrypoint.sh

Loading...

services/swh-web/entrypoint.sh

Loading...