This makes the symbolic references sent from upstream branch aliases in
snapshots, instead of pointing to the target.
Details
- Reviewers
zack ardumont - Commits
- rDLDG485419f21851: Add support for symbolic references
tox
Diff Detail
- Repository
- rDLDG Git loader
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 8141 Build 11733: tox-on-jenkins Jenkins Build 11732: arc lint + arc unit
Event Timeline
Build is green
See https://jenkins.softwareheritage.org/job/DLDG/job/tox/102/ for more details.
Looks good, but I'm puzzled by some testing results.
The logic of extracting the branches for snapshot computation has trickled down to swh identify. (BTW, if you're up for some refactoring, this diff might be a chance to avoid the duplication, but it's certainly not a blocker here.)
So I've tried to just reuse your change in swh.model.cli too, here's the minimal diff: D2081.
Then I've dumped the branch list just before it's hashed (with P542 in swh.model.identifiers) and what I get is this:
alias HEAD 726566732f68656164732f6d6173746572 revision refs/heads/master 9768d0b576dbaaecd80abedad6dfd0d72f1476da revision refs/remotes/origin/master c3c588713233609f5bbbb2d9e7f3fb4a660f3f72
where HEAD is an alias, but it's pointing to an object ID (this is on the sample git repo used for tests on swh-load-git, but I obtain similar results on any other repo I've tried).
What am I missing here?
I think your code is fine, but we want compatibility with what swh.model.identifiers does, and I don't understand why it's not the case with my proposed trivial change.
That's not an object id, that's a branch name (refs/heads/master, in ASCII).
I think your code is fine, but we want compatibility with what swh.model.identifiers does, and I don't understand why it's not the case with my proposed trivial change.
Build is green
See https://jenkins.softwareheritage.org/job/DLDG/job/tox/103/ for more details.