Page MenuHomeSoftware Heritage
Differential D1756

cypress: Test Language-select
ClosedPublic
Actions

Authored by kalpitk on Jul 19 2019, 9:45 PM.

Details

Reviewers
anlambert
Group Reviewers
Reviewers
Commits
rDWAPPS393deaa5b18c: cypress: Add Language Select Tests
Summary

Tests for D1732
Related T1909

Depends on D1672 for checkLanguageHighlighting function.

Diff Detail

Repository
rDWAPPS Web applications
Branch
testlanguageSelect
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 7150
Build 10087: Cypress tests for swh-web diffsJenkins
Build 10086: tox-on-jenkinsJenkins
Build 10085: arc lint + arc unit

Event Timeline

kalpitk created this revision.Jul 19 2019, 9:45 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJul 19 2019, 9:45 PM
kalpitk retitled this revision from cypress: Test Language-select to [WIP] cypress: Test Language-select.Jul 19 2019, 9:47 PM
kalpitk edited the summary of this revision. (Show Details)
swh-public-ci added a comment.Jul 19 2019, 9:48 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/623/ for more details.

swh-public-ci added a comment.Jul 19 2019, 9:54 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/219/ for more details.

Harbormaster completed remote builds in B6952: Diff 5916.Jul 19 2019, 9:54 PM
kalpitk updated this revision to Diff 5925.Jul 22 2019, 10:38 PM
  • Add tests
swh-public-ci added a comment.Jul 22 2019, 10:41 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/624/ for more details.

swh-public-ci added a comment.Jul 22 2019, 10:44 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/220/ for more details.

Harbormaster completed remote builds in B6961: Diff 5925.Jul 22 2019, 10:44 PM
kalpitk mentioned this in D1672: Add end to end tests for content rendering.Jul 23 2019, 2:39 PM
kalpitk updated this revision to Diff 5938.Jul 23 2019, 3:36 PM
  • refector tests
swh-public-ci added a comment.Jul 23 2019, 3:42 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/626/ for more details.

swh-public-ci added a comment.Jul 23 2019, 3:43 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/222/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/222/console

Harbormaster failed remote builds in B6978: Diff 5938!Jul 23 2019, 3:43 PM
kalpitk updated this revision to Diff 5977.Jul 25 2019, 9:00 AM

import checkLangaugeHighlighing from utils

kalpitk retitled this revision from [WIP] cypress: Test Language-select to cypress: Test Language-select.Jul 25 2019, 9:03 AM
kalpitk edited the summary of this revision. (Show Details)
kalpitk added a parent revision: D1672: Add end to end tests for content rendering.
swh-public-ci added a comment.Jul 25 2019, 9:05 AM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/630/ for more details.

swh-public-ci added a comment.Jul 25 2019, 9:08 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/226/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/226/console

Harbormaster failed remote builds in B7018: Diff 5977!Jul 25 2019, 9:08 AM
kalpitk updated this revision to Diff 6118.Aug 5 2019, 2:16 PM

rebase with master

swh-public-ci added a comment.Aug 5 2019, 2:21 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/650/ for more details.

swh-public-ci added a comment.Aug 5 2019, 2:28 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/246/ for more details.

Harbormaster completed remote builds in B7150: Diff 6118.Aug 5 2019, 2:28 PM
anlambert accepted this revision.Aug 5 2019, 2:55 PM
anlambert added a subscriber: anlambert.

Apart a small nitpick, looks good to me.

cypress/integration/language-select.spec.js
28

async keyword is not required here

This revision is now accepted and ready to land.Aug 5 2019, 2:55 PM
kalpitk updated this revision to Diff 6126.Aug 5 2019, 4:43 PM

remove unnecessary async

swh-public-ci added a comment.Aug 5 2019, 4:48 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/651/ for more details.

swh-public-ci added a comment.Aug 5 2019, 4:52 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/247/ for more details.

Harbormaster completed remote builds in B7157: Diff 6126.Aug 5 2019, 4:52 PM
kalpitk updated this revision to Diff 6127.Aug 5 2019, 5:34 PM

rebase

swh-public-ci added a comment.Aug 5 2019, 5:39 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/652/ for more details.

swh-public-ci added a comment.Aug 5 2019, 5:43 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/248/ for more details.

Harbormaster completed remote builds in B7158: Diff 6127.Aug 5 2019, 5:43 PM
Closed by commit rDWAPPS393deaa5b18c: cypress: Add Language Select Tests (authored by kalpitk). · Explain WhyAug 5 2019, 6:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
cypress/
integration/
90 lines
utils/
5 lines

Diff 6118

View Options

cypress/integration/language-select.spec.js

Loading...
View Options

cypress/utils/index.js

Loading...
About · Developer information · Legal