Page MenuHomeSoftware Heritage

cypress: Test Language-select
ClosedPublic

Authored by kalpitk on Jul 19 2019, 9:45 PM.

Details

Summary

Tests for D1732
Related T1909

Depends on D1672 for checkLanguageHighlighting function.

Diff Detail

Repository
rDWAPPS Web applications
Branch
testlanguageSelect
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6978
Build 9823: Cypress tests for swh-web diffsJenkins
Build 9822: tox-on-jenkinsJenkins
Build 9821: arc lint + arc unit

Event Timeline

kalpitk retitled this revision from cypress: Test Language-select to [WIP] cypress: Test Language-select.Jul 19 2019, 9:47 PM
kalpitk edited the summary of this revision. (Show Details)

import checkLangaugeHighlighing from utils

kalpitk retitled this revision from [WIP] cypress: Test Language-select to cypress: Test Language-select.Jul 25 2019, 9:03 AM
kalpitk edited the summary of this revision. (Show Details)
anlambert added a subscriber: anlambert.

Apart a small nitpick, looks good to me.

cypress/integration/language-select.spec.js
28

async keyword is not required here

This revision is now accepted and ready to land.Aug 5 2019, 2:55 PM
This revision was automatically updated to reflect the committed changes.