Page MenuHomeSoftware Heritage

cypress: Test Language-select
ClosedPublic

Authored by kalpitk on Jul 19 2019, 9:45 PM.

Details

Summary

Tests for D1732
Related T1909

Depends on D1672 for checkLanguageHighlighting function.

Diff Detail

Repository
rDWAPPS Web applications
Branch
testlanguageSelect
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 7018
Build 9879: Cypress tests for swh-web diffsJenkins
Build 9878: tox-on-jenkinsJenkins
Build 9877: arc lint + arc unit

Event Timeline

kalpitk created this revision.Jul 19 2019, 9:45 PM
kalpitk retitled this revision from cypress: Test Language-select to [WIP] cypress: Test Language-select.Jul 19 2019, 9:47 PM
kalpitk edited the summary of this revision. (Show Details)
kalpitk updated this revision to Diff 5925.Jul 22 2019, 10:38 PM
  • Add tests
kalpitk updated this revision to Diff 5938.Jul 23 2019, 3:36 PM
  • refector tests
kalpitk updated this revision to Diff 5977.Jul 25 2019, 9:00 AM

import checkLangaugeHighlighing from utils

kalpitk retitled this revision from [WIP] cypress: Test Language-select to cypress: Test Language-select.Jul 25 2019, 9:03 AM
kalpitk edited the summary of this revision. (Show Details)
kalpitk updated this revision to Diff 6118.Aug 5 2019, 2:16 PM

rebase with master

anlambert accepted this revision.Aug 5 2019, 2:55 PM
anlambert added a subscriber: anlambert.

Apart a small nitpick, looks good to me.

cypress/integration/language-select.spec.js
29

async keyword is not required here

This revision is now accepted and ready to land.Aug 5 2019, 2:55 PM
kalpitk updated this revision to Diff 6126.Aug 5 2019, 4:43 PM

remove unnecessary async

This revision was automatically updated to reflect the committed changes.