Page MenuHomeSoftware Heritage

cypress: Test Language-select
ClosedPublic

Authored by kalpitk on Jul 19 2019, 9:45 PM.

Details

Summary

Tests for D1732
Related T1909

Depends on D1672 for checkLanguageHighlighting function.

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kalpitk created this revision.Jul 19 2019, 9:45 PM
kalpitk retitled this revision from cypress: Test Language-select to [WIP] cypress: Test Language-select.Jul 19 2019, 9:47 PM
kalpitk edited the summary of this revision. (Show Details)
kalpitk updated this revision to Diff 5925.Mon, Jul 22, 10:38 PM
  • Add tests
kalpitk updated this revision to Diff 5938.Tue, Jul 23, 3:36 PM
  • refector tests
kalpitk updated this revision to Diff 5977.Thu, Jul 25, 9:00 AM

import checkLangaugeHighlighing from utils

kalpitk retitled this revision from [WIP] cypress: Test Language-select to cypress: Test Language-select.Thu, Jul 25, 9:03 AM
kalpitk edited the summary of this revision. (Show Details)
kalpitk updated this revision to Diff 6118.Mon, Aug 5, 2:16 PM

rebase with master

anlambert accepted this revision.Mon, Aug 5, 2:55 PM
anlambert added a subscriber: anlambert.

Apart a small nitpick, looks good to me.

cypress/integration/language-select.spec.js
29

async keyword is not required here

This revision is now accepted and ready to land.Mon, Aug 5, 2:55 PM
kalpitk updated this revision to Diff 6126.Mon, Aug 5, 4:43 PM

remove unnecessary async

This revision was automatically updated to reflect the committed changes.