Page MenuHomeSoftware Heritage

Finish dropping the 'description' column.
ClosedPublic

Authored by vlorentz on Jun 26 2019, 2:36 PM.

Details

Summary

I missed some in aef7d5952e16a9e877b5a3846ff6aaac0725eb4e.

Diff Detail

Repository
rDLS Listers
Branch
drop-description
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6503
Build 9053: tox-on-jenkinsJenkins
Build 9052: arc lint + arc unit

Event Timeline

ardumont added a subscriber: ardumont.

Have you tried starting the docker-dev then?

This revision is now accepted and ready to land.Jun 26 2019, 2:37 PM

Have you tried starting the docker-dev then?

Tests are not enough apparently so i'd settle with that check for now.

I checked with docker, it indeed fixes the issue

nahimilega added inline comments.
swh/lister/cran/lister.py
27–30

The only way to get some metadata and description related to a packages is using R build in api. If we remove description from here then we will not have any metadata related to package which could be used in loader.

Have you tried starting the docker-dev then?

Tests are not enough apparently so i'd settle with that check for now.

And starting listing a gitlab instance as that'd be also not enough.

This revision was landed with ongoing or failed builds.Jun 26 2019, 2:46 PM
This revision was automatically updated to reflect the committed changes.
swh/lister/cran/lister.py
27–30

What will this metadata be used for?

swh/lister/cran/lister.py
27–30

As in other loaders(like pypi) there the is metadata url wich the loader visits and collect some data related to the package like author name and description.
Same here but instead of giving the link of metadata url, we directly give metadata(that is description) which could be used in loader in same way as author name or description is used in pypi loader

swh/lister/cran/lister.py
27–30

Oh, right. Could you make a diff to restore this behavior (and add a test so it does not accidentally get removed again)?

swh/lister/cran/lister.py
27–30

I will surely make a diff to restore it, but I am not sure about the test. I didn't understood how to make the test for this and of what type. Some example would be really helpful here

swh/lister/cran/lister.py
27–30

With assert_called_once_with:

with unittest.mock.patch('swh.scheduler.<blahblah>.create_tasks') as mock_create_tasks:
    # call the lister here
mock_create_tasks.assert_called_once_with(blah blah)