Page MenuHomeSoftware Heritage
Differential D1586

Don't use a join in origin_visit_get_latest.
ClosedPublic
Actions

Authored by vlorentz on Jun 14 2019, 1:55 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDSTOCb139393e7ac4: Don't use a join in origin_visit_get_latest.
rDSTOb139393e7ac4: Don't use a join in origin_visit_get_latest.
Summary

This changes the behavior of snapshot_get_latest, to raise an
error in case a visit references an unknown snapshot.
This should not happen in practice (unless we're replaying
from a journal).

snapshot_get_latest will be removed in the next monthes anyway.

Diff Detail

Repository
rDSTO Storage manager
Branch
origin_visit_get_latest-nojoin
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6216
Build 8583: tox-on-jenkinsJenkins
Build 8582: arc lint + arc unit

Event Timeline

vlorentz created this revision.Jun 14 2019, 1:55 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJun 14 2019, 1:55 PM
vlorentz updated this revision to Diff 5244.Jun 14 2019, 1:56 PM

remove print statement.

vlorentz updated this revision to Diff 5245.Jun 14 2019, 1:56 PM

remove print statement.

swh-public-ci added a comment.Jun 14 2019, 2:02 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/489/ for more details.

Harbormaster completed remote builds in B6216: Diff 5243.Jun 14 2019, 2:02 PM
swh-public-ci added a comment.Jun 14 2019, 2:03 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/490/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/490/console

Harbormaster failed remote builds in B6217: Diff 5244!Jun 14 2019, 2:03 PM
swh-public-ci added a comment.Jun 14 2019, 2:10 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/491/ for more details.

Harbormaster completed remote builds in B6218: Diff 5245.Jun 14 2019, 2:10 PM
ardumont accepted this revision as: ardumont.Jun 19 2019, 10:03 AM
ardumont added subscribers: olasd, ardumont.

sound good to me

@olasd any thoughts on this?

This revision is now accepted and ready to land.Jun 19 2019, 10:03 AM
olasd added a comment.Jun 19 2019, 2:26 PM
In D1586#36460, @ardumont wrote:

sound good to me

@olasd any thoughts on this?

I think we talked with @vlorentz about that IRL and I said the join was just a remnant of the old data model (where origin_visit -> snapshot used an opaque identifier)

vlorentz updated this revision to Diff 5357.Jun 19 2019, 2:34 PM

rebase

This revision was landed with ongoing or failed builds.Jun 19 2019, 2:34 PM
Closed by commit rDSTOb139393e7ac4: Don't use a join in origin_visit_get_latest. (authored by vlorentz). · Explain Why
This revision was automatically updated to reflect the committed changes.
Harbormaster failed remote builds in B6338: Diff 5357!Jun 19 2019, 2:35 PM
swh-public-ci added a comment.Jun 19 2019, 2:35 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/503/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/503/console

Revision Contents
Changeset List

PathSize
swh/
storage/
5 lines
9 lines
8 lines
tests/
26 lines

Diff 5243

View Options

swh/storage/db.py

Loading...
View Options

swh/storage/in_memory.py

Loading...
View Options

swh/storage/storage.py

Loading...
View Options

swh/storage/tests/test_storage.py

Loading...
About · Developer information · Legal