Page MenuHomeSoftware Heritage

Don't use a join in origin_visit_get_latest.
ClosedPublic

Authored by vlorentz on Jun 14 2019, 1:55 PM.

Details

Summary

This changes the behavior of snapshot_get_latest, to raise an
error in case a visit references an unknown snapshot.
This should not happen in practice (unless we're replaying
from a journal).

snapshot_get_latest will be removed in the next monthes anyway.

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Jun 14 2019, 1:55 PM
vlorentz updated this revision to Diff 5244.Jun 14 2019, 1:56 PM

remove print statement.

vlorentz updated this revision to Diff 5245.Jun 14 2019, 1:56 PM

remove print statement.

ardumont accepted this revision as: ardumont.Jun 19 2019, 10:03 AM
ardumont added subscribers: olasd, ardumont.

sound good to me

@olasd any thoughts on this?

This revision is now accepted and ready to land.Jun 19 2019, 10:03 AM
olasd added a comment.Jun 19 2019, 2:26 PM

sound good to me
@olasd any thoughts on this?

I think we talked with @vlorentz about that IRL and I said the join was just a remnant of the old data model (where origin_visit -> snapshot used an opaque identifier)

This revision was landed with ongoing or failed builds.Jun 19 2019, 2:34 PM
This revision was automatically updated to reflect the committed changes.