Page MenuHomeSoftware Heritage
Differential D1391

swh-web: enforce the database file to be created in either $HOME or /tmp
ClosedPublic
Actions

Authored by douardda on Apr 10 2019, 12:23 PM.

Details

Reviewers
anlambert
Group Reviewers
Reviewers
Commits
rDENV20b0733b84f3: swh-web: enforce the database file to be created in either $HOME or /tmp
rCDFD20b0733b84f3: swh-web: enforce the database file to be created in either $HOME or /tmp
Summary

but NOT in the swh-web python package.

Needed to be able to run swh-web installed from source in a docker
in which the code runs as swh user.

Diff Detail

Repository
rCDFD Dockerfiles for developers
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Apr 10 2019, 12:23 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptApr 10 2019, 12:23 PM
Harbormaster completed remote builds in B5297: Diff 4487.Apr 10 2019, 12:23 PM
douardda added a child revision: D1392: lister: Use explicit postgresql URLs as a workaround for a sqlalchemy issue.Apr 10 2019, 12:23 PM
olasd added subscribers: anlambert, olasd.Apr 10 2019, 1:13 PM

Looks sensible to me but we probably need a second opinion from @anlambert

anlambert added a comment.Apr 10 2019, 1:40 PM

I would rather adapt swh-web configuration in order to specify the database file to use.

Duplicating Django developement settings seems wrong to me as we will have to synchronize
it with every changes in swh.web.setting.development.

@douardda , any objection on this ?

anlambert mentioned this in T1639: Allow to specify development database file.Apr 10 2019, 2:13 PM
anlambert mentioned this in D1396: config: Allow to specify development database file.Apr 10 2019, 2:19 PM
anlambert accepted this revision.Apr 10 2019, 2:36 PM

Accepting this, I will update swh-web configuration afterwards.

This revision is now accepted and ready to land.Apr 10 2019, 2:36 PM
Closed by commit rCDFD20b0733b84f3: swh-web: enforce the database file to be created in either $HOME or /tmp (authored by douardda). · Explain WhyApr 10 2019, 2:40 PM
This revision was automatically updated to reflect the committed changes.
douardda added a commit: rDENV20b0733b84f3: swh-web: enforce the database file to be created in either $HOME or /tmp.Nov 26 2019, 1:35 PM

Revision Contents
Changeset List

PathSize
6 lines
services/
swh-web/
12 lines

Diff 4494

View Options

docker-compose.yml

Loading...
View Options

services/swh-web/settings.py

Loading...
About · Developer information · Legal