When two revisions/releases have authors with the same fullname
but different names (which should never happen in practice, but
since name/email parsing is on a best-effort basis, you never
know...).
Bug found by Hypothesis.
Paths
| Differential D1378 Authored by vlorentz on Apr 9 2019, 4:24 PM.
Details Summary When two revisions/releases have authors with the same fullname Bug found by Hypothesis.
Diff Detail
Event TimelineHerald added a reviewer: Reviewers. · View Herald TranscriptApr 9 2019, 4:24 PM2019-04-09 16:24:45 (UTC+2) Comment Actions Build has FAILED Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/329/ Harbormaster failed remote builds in B5239: Diff 4431!Apr 9 2019, 4:37 PM2019-04-09 16:37:13 (UTC+2) Comment Actions Sometimes, I wonder if we wouldn't be better off dropping the name and email parsed fields and only keeping fullname in the database... In any case, the test would be less surprising if both authors were "sensible" parsings of the same fullname. For instance, fullname = 'John Doe <john.doe@example.com>' (two spaces) can sensibly parse to name = 'John Doe', email = 'john.doe@example.com', as well as name = 'John Doe ', email = 'john.doe@example.com' (with the trailing space). This revision is now accepted and ready to land.Apr 9 2019, 4:49 PM2019-04-09 16:49:22 (UTC+2) vlorentz added a parent revision: D1382: Fix order of results of person_get..Apr 9 2019, 5:01 PM2019-04-09 17:01:14 (UTC+2) Comment Actions Build has FAILED Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/338/ Harbormaster failed remote builds in B5250: Diff 4442!Apr 9 2019, 5:22 PM2019-04-09 17:22:06 (UTC+2) Comment Actions Build has FAILED Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/350/ Comment Actions Build is green Harbormaster completed remote builds in B5273: Diff 4465.Apr 9 2019, 5:56 PM2019-04-09 17:56:09 (UTC+2) Closed by commit rDSTOcd0d309850f0: Fix person name clashes in revision_add and release_add. (authored by vlorentz). · Explain WhyApr 9 2019, 5:56 PM2019-04-09 17:56:32 (UTC+2) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 4442 swh/storage/sql/40-swh-func.sql
swh/storage/tests/test_storage.py
|