Page MenuHomeSoftware Heritage
Differential D1363

Add support for slices in Storage.content_get (T1446)
AbandonedPublic
Actions

Authored by vlorentz on Apr 5 2019, 11:54 PM.
This revision can not be accepted until the required legal agreements have been signed.

Details

Reviewers
Sowmya
Group Reviewers
Reviewers
Required Signatures
L3 Software Heritage Contributor License Agreement, version 1.0
Summary

Changes are to be made in "Storage.content_get" to support the slicing of the data of full blob returned to it.
To execute this , two new parameters are added as an argument to the function "content_get()" to specify the rand of bytes that the caller requires
and also to pass them to the obstorage. Same changes have been made to both the files "swh/storage/in_memory.py" and "swh/storage/storage.py"

Diff Detail

Repository
rDSTO Storage manager
Branch
data_slicing
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5163
Build 6954: tox-on-jenkinsJenkins
Build 6953: arc lint + arc unit

Event Timeline

Sowmya created this revision.Apr 5 2019, 11:54 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptApr 5 2019, 11:54 PM
Herald added a required legal document: L3 Software Heritage Contributor License Agreement, version 1.0. · View Herald Transcript
swh-public-ci added a comment.Apr 5 2019, 11:55 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/310/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/310/console

Harbormaster failed remote builds in B5163: Diff 4360!Apr 5 2019, 11:55 PM
Sowmya updated this revision to Diff 4361.Apr 6 2019, 12:03 AM

The parameter in the function (i.e. start and end) were not specified in earlier version, so correcting it.

swh-public-ci added a comment.Apr 6 2019, 12:04 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/311/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/311/console

Harbormaster failed remote builds in B5164: Diff 4361!Apr 6 2019, 12:04 AM
Sowmya updated this revision to Diff 4362.Apr 6 2019, 12:09 AM

correction made based on console result.

swh-public-ci added a comment.Apr 6 2019, 12:15 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/312/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/312/console

Harbormaster failed remote builds in B5165: Diff 4362!Apr 6 2019, 12:15 AM
swh-public-ci added a comment.Apr 6 2019, 12:42 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/313/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/313/console

anlambert added a subscriber: anlambert.Apr 6 2019, 1:43 AM

Thanks for the contribution but there is still some actions required from your side in order for the Software Heritage developers to review your changes:

anlambert mentioned this in D1362: in-memory storage: compute missing counters.Apr 6 2019, 1:45 AM
Sowmya updated this revision to Diff 4363.Apr 6 2019, 9:25 AM

Signed the legal docs

vlorentz added a subscriber: vlorentz.Apr 6 2019, 9:30 AM

Hi,

The task you are trying to solve (T1446, support of slices in swh-storage) depends on a much harder task (T1447, support of slices in swh-objstorage), so you shouldn't try to fix it now.

Sorry for tagging it as "easy hack", I underestimated the complexity of T1447.

swh-public-ci added a comment.Apr 6 2019, 9:31 AM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/314/ for more details.

Harbormaster completed remote builds in B5166: Diff 4363.Apr 6 2019, 9:31 AM
Sowmya added a comment.Apr 6 2019, 4:42 PM

@vloretz thank you so much and I shall take note of that. Does that mean
that my submission wouldn’t be revised and the patch wouldn’t be submitted
? Also, please let me know if I could be able to contribute to any other
hacks related to this hack.

Sowmya updated this revision to Diff 4397.Apr 8 2019, 9:26 PM
  • in-memory storage: compute all missing counters
swh-public-ci added a comment.Apr 8 2019, 9:32 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/319/ for more details.

Harbormaster completed remote builds in B5205: Diff 4397.Apr 8 2019, 9:32 PM
ardumont added a subscriber: ardumont.Apr 9 2019, 1:20 PM
ardumont added inline comments.
.coverage.paris.28594.210279
2 ↗(On Diff #4397)

For your information, those files (probably generated by tox or pytest) should not be committed.

vlorentz requested changes to this revision.May 6 2019, 11:42 AM
This revision now requires changes to proceed.May 6 2019, 11:42 AM
vlorentz commandeered this revision.Jul 1 2019, 5:20 PM
vlorentz abandoned this revision.
vlorentz edited reviewers, added: Sowmya; removed: vlorentz.

Content Hidden

The content of this revision is hidden until the author has signed all of the required legal agreements.
About · Developer information · Legal