Page MenuHomeSoftware Heritage
Differential D1362

in-memory storage: compute missing counters
AbandonedPublic
Actions

Authored by vlorentz on Apr 5 2019, 9:33 PM.
This revision can not be accepted until the required legal agreements have been signed.

Details

Reviewers
Sowmya
Group Reviewers
Reviewers
Maniphest Tasks
T1377: in-memory storage: compute all counters
Required Signatures
L3 Software Heritage Contributor License Agreement, version 1.0
Summary

In order to count "person", "origin_visit", and "skipped_content" objects, changes have been made in the functions
"_person_add()","origin_visit_add()" and "content_add()" respectively. This issue has been fixed by adding entries to self._object which
shall be counted by "in_memory.Storage.stat_counter()" function.

Diff Detail

Repository
rDSTO Storage manager
Branch
compute_all_counter
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5208
Build 7034: tox-on-jenkinsJenkins
Build 7033: arc lint + arc unit

Event Timeline

Sowmya created this revision.Apr 5 2019, 9:33 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptApr 5 2019, 9:33 PM
Herald added a required legal document: L3 Software Heritage Contributor License Agreement, version 1.0. · View Herald Transcript
Harbormaster failed remote builds in B5162: Diff 4359!Apr 5 2019, 9:33 PM
swh-public-ci added a comment.Apr 5 2019, 9:33 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/309/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/309/console

anlambert added a subscriber: anlambert.Apr 6 2019, 1:45 AM

Same comment as in D1363 (https://forge.softwareheritage.org/D1363#29501)

anlambert retitled this revision from # Enter a commit message. # # Changes: # # swh/storage/in_memory.py To compute "person", "origin_visit", and "skipped_content" objects (T1377) to in-memory storage: compute missing counters.Apr 6 2019, 1:46 AM
vlorentz added a task: T1377: in-memory storage: compute all counters.Apr 8 2019, 11:25 AM
Sowmya updated this revision to Diff 4400.Apr 9 2019, 6:30 AM

Required revision are made.

swh-public-ci added a comment.Apr 9 2019, 6:36 AM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/322/ for more details.

Harbormaster completed remote builds in B5208: Diff 4400.Apr 9 2019, 6:36 AM
vlorentz added a subscriber: vlorentz.Apr 9 2019, 9:47 AM

Could you remove the slicing changes from this diff, and change the test(s?) for the counters to take these new counters into account?

vlorentz requested changes to this revision.Apr 9 2019, 9:47 AM
This revision now requires changes to proceed.Apr 9 2019, 9:47 AM
vlorentz commandeered this revision.Jun 5 2019, 2:58 PM
vlorentz abandoned this revision.
vlorentz edited reviewers, added: Sowmya; removed: vlorentz.

Content Hidden

The content of this revision is hidden until the author has signed all of the required legal agreements.
About · Developer information · Legal