Page MenuHomeSoftware Heritage

in-memory storage: compute missing counters
AbandonedPublic

Authored by vlorentz on Apr 5 2019, 9:33 PM.
This revision can not be accepted until the required legal agreements have been signed.

Details

Summary

In order to count "person", "origin_visit", and "skipped_content" objects, changes have been made in the functions
"_person_add()","origin_visit_add()" and "content_add()" respectively. This issue has been fixed by adding entries to self._object which
shall be counted by "in_memory.Storage.stat_counter()" function.

Diff Detail

Repository
rDSTO Storage manager
Branch
compute_all_counter
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5208
Build 7034: tox-on-jenkinsJenkins
Build 7033: arc lint + arc unit

Event Timeline

Sowmya created this revision.Apr 5 2019, 9:33 PM
anlambert retitled this revision from # Enter a commit message. # # Changes: # # swh/storage/in_memory.py To compute "person", "origin_visit", and "skipped_content" objects (T1377) to in-memory storage: compute missing counters.Apr 6 2019, 1:46 AM
Sowmya updated this revision to Diff 4400.Apr 9 2019, 6:30 AM

Required revision are made.

Could you remove the slicing changes from this diff, and change the test(s?) for the counters to take these new counters into account?

vlorentz requested changes to this revision.Apr 9 2019, 9:47 AM
This revision now requires changes to proceed.Apr 9 2019, 9:47 AM
vlorentz commandeered this revision.Jun 5 2019, 2:58 PM
vlorentz abandoned this revision.
vlorentz edited reviewers, added: Sowmya; removed: vlorentz.

Content Hidden

The content of this revision is hidden until the author has signed all of the required legal agreements.