This allows to pass the configuration needed to the publisher.
I extracted that from the current work i'm doing on testing kafka.
That allows to unblock other coming changes needed (impact on
swh-docker-dev, swh-site).
Related T1410
Details
Details
- Reviewers
douardda vlorentz - Group Reviewers
Reviewers - Commits
- rDJNLbd580500b619: publisher: Initiate the journal cli to start running the publisher
tox
Diff Detail
Diff Detail
- Repository
- rDJNL Journal infrastructure
- Branch
- new-cli
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 4661 Build 6195: tox-on-jenkins Jenkins Build 6194: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DJNL/job/tox/36/ for more details.
Comment Actions
Accepted, but let's not forget to add tests for the CLI
| swh/journal/cli.py | ||
|---|---|---|
| 76–77 | Add an except KeyboardException to exit the loop nicely. | |
Comment Actions
Thanks for the remarks.
Yes, for the test on cli.
I planned to do that but not right now.
My main focus right now is being able to test the kafka layer for now ;)
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DJNL/job/tox/37/ for more details.