Page MenuHomeSoftware Heritage
Differential D1249

publisher: Simplify publisher initialization and add journal cli
ClosedPublic
Actions

Authored by ardumont on Mar 15 2019, 12:10 PM.

Details

Reviewers
douardda
vlorentz
Group Reviewers
Reviewers
Commits
rDJNLbd580500b619: publisher: Initiate the journal cli to start running the publisher
Summary

This allows to pass the configuration needed to the publisher.

I extracted that from the current work i'm doing on testing kafka.
That allows to unblock other coming changes needed (impact on
swh-docker-dev, swh-site).

Related T1410

Test Plan

tox

Diff Detail

Repository
rDJNL Journal infrastructure
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Mar 15 2019, 12:10 PM
swh-public-ci added a subscriber: swh-public-ci.Mar 15 2019, 12:12 PM

Build is green
See https://jenkins.softwareheritage.org/job/DJNL/job/tox/36/ for more details.

Harbormaster completed remote builds in B4656: Diff 3941.Mar 15 2019, 12:12 PM
ardumont marked an inline comment as done.Mar 15 2019, 12:19 PM
ardumont added inline comments.
swh/journal/tests/test_publisher.py
148

That will be reworked in D1239.

ardumont mentioned this in D1250: journal-publisher: Update the journal publisher entrypoint.Mar 15 2019, 12:20 PM
ardumont added a reviewer: vlorentz.Mar 15 2019, 12:21 PM
ardumont added a project: Journal.
vlorentz accepted this revision.Mar 15 2019, 12:22 PM

Accepted, but let's not forget to add tests for the CLI

swh/journal/cli.py
76–77

Add an except KeyboardException to exit the loop nicely.

This revision is now accepted and ready to land.Mar 15 2019, 12:22 PM
vlorentz added inline comments.Mar 15 2019, 12:23 PM
swh/journal/cli.py
72–73

raise a ClickException instead.

72–73

And reword to: Configuration error: The following keys must be provided: %s

ardumont mentioned this in D1251: publisher: Adapt according to latest development.Mar 15 2019, 12:35 PM
ardumont added a comment.Mar 15 2019, 1:12 PM

Thanks for the remarks.

Yes, for the test on cli.
I planned to do that but not right now.
My main focus right now is being able to test the kafka layer for now ;)

ardumont updated this revision to Diff 3946.Mar 15 2019, 1:43 PM

Adapt according to review

swh-public-ci added a comment.Mar 15 2019, 1:44 PM

Build is green
See https://jenkins.softwareheritage.org/job/DJNL/job/tox/37/ for more details.

Harbormaster completed remote builds in B4661: Diff 3946.Mar 15 2019, 1:45 PM
Closed by commit rDJNLbd580500b619: publisher: Initiate the journal cli to start running the publisher (authored by ardumont). · Explain WhyMar 15 2019, 1:50 PM
This revision was automatically updated to reflect the committed changes.
ardumont mentioned this in D1239: swh-journal: Add tests to the journal publisher using kafka instance.Mar 15 2019, 1:54 PM
ardumont mentioned this in rSPSITE018976473337: publisher: Adapt according to latest development.Mar 15 2019, 1:58 PM

Revision Contents
Changeset List

PathSize
4 lines
swh/
journal/
89 lines
55 lines
tests/
30 lines

Diff 3948

View Options

setup.py

Loading...
View Options

swh/journal/cli.py

Loading...
View Options

swh/journal/publisher.py

Loading...
View Options

swh/journal/tests/test_publisher.py

Loading...
About · Developer information · Legal