Page MenuHomeSoftware Heritage
Differential D1167

api.server: Make the api server use explicit configuration
ClosedPublic
Actions

Authored by ardumont on Feb 21 2019, 12:26 PM.

Details

Reviewers
douardda
vlorentz
Group Reviewers
Reviewers
Commits
rDSTOC95b0b42e0e77: api.server: Use the right Exception for the job
rDSTOC247ab97b103a: test_server: Refactor and fix issue for pytest on python3.5
rDSTOCa2db5ef1b5d6: api.server: Remove unused import
rDSTOC2d500d100da2: api.wsgi: Open wsgi entrypoint and check config at startup time
rDSTOCb38ecc05649c: swh.storage.cli: Migrate the api server startup in swh.storage.cli
rDSTOC750e292a2839: api.server: Remove implicit config from
rDSTOC2696b47e3e48: api.server: Make the api server load and check its configuration
R65:95b0b42e0e77: api.server: Use the right Exception for the job
R65:a2db5ef1b5d6: api.server: Remove unused import
R65:247ab97b103a: test_server: Refactor and fix issue for pytest on python3.5
R65:2696b47e3e48: api.server: Make the api server load and check its configuration
R65:750e292a2839: api.server: Remove implicit config from
R65:2d500d100da2: api.wsgi: Open wsgi entrypoint and check config at startup time
R65:b38ecc05649c: swh.storage.cli: Migrate the api server startup in swh.storage.cli
rDSTO95b0b42e0e77: api.server: Use the right Exception for the job
rDSTO247ab97b103a: test_server: Refactor and fix issue for pytest on python3.5
rDSTOb38ecc05649c: swh.storage.cli: Migrate the api server startup in swh.storage.cli
rDSTOa2db5ef1b5d6: api.server: Remove unused import
rDSTO2d500d100da2: api.wsgi: Open wsgi entrypoint and check config at startup time
rDSTO750e292a2839: api.server: Remove implicit config from
rDSTO2696b47e3e48: api.server: Make the api server load and check its configuration
Summary
  • Remove implicit config from
  • Open wsgi entrypoint
  • check config at startup time
  • Open a new swh.storage.cli to start the api server

Related T1533

Test Plan

tox

Diff Detail

Repository
rDSTO Storage manager
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4366
Build 5773: tox-on-jenkinsJenkins
Build 5772: arc lint + arc unit

Event Timeline

ardumont created this revision.Feb 21 2019, 12:26 PM
swh-public-ci added a subscriber: swh-public-ci.Feb 21 2019, 12:29 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/200/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/200/console

Harbormaster failed remote builds in B4363: Diff 3684!Feb 21 2019, 12:29 PM
ardumont added a child revision: D1168: swh-storage: Unify production and development start up.Feb 21 2019, 12:31 PM
ardumont added a comment.Feb 21 2019, 1:14 PM

Build has FAILED

/me raises an eyebrow

Apparently some version issue, fine locally, but the ci disagrees with:
TypeError: argument should be string, bytes or integer, not LocalPath

Checking that.
The gist of the diff can still be reviewed.

vlorentz accepted this revision.Feb 21 2019, 1:15 PM
vlorentz added a subscriber: vlorentz.
vlorentz added inline comments.
swh/storage/api/server.py
386–390

You could use FileNotFoundError.

395

KeyError

401–409

ValueError

swh/storage/tests/test_server.py
72

Should be toplevel

This revision is now accepted and ready to land.Feb 21 2019, 1:15 PM
ardumont updated this revision to Diff 3687.Feb 21 2019, 1:24 PM
  • test_server: Refactor and fix issue for pytest on python3.5
ardumont marked an inline comment as done.Feb 21 2019, 1:27 PM
swh-public-ci added a comment.Feb 21 2019, 1:27 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/202/ for more details.

Harbormaster completed remote builds in B4366: Diff 3687.Feb 21 2019, 1:27 PM
ardumont updated this revision to Diff 3688.Feb 21 2019, 1:29 PM
  • api.server: Use the right Exception for the job
ardumont added a comment.Feb 21 2019, 1:30 PM

Thanks for the feedback!

Adapted.

swh-public-ci added a comment.Feb 21 2019, 1:32 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/203/ for more details.

Harbormaster completed remote builds in B4367: Diff 3688.Feb 21 2019, 1:32 PM
Closed by commit rDSTO2696b47e3e48: api.server: Make the api server load and check its configuration (authored by ardumont). · Explain WhyFeb 21 2019, 1:33 PM
This revision was automatically updated to reflect the committed changes.
ardumont mentioned this in D1169: storage: Use new wsgi entrypoint.Feb 21 2019, 1:38 PM
ardumont mentioned this in D1170: indexer.storage: Make server load and check explicit configuration.Feb 21 2019, 2:19 PM
ardumont mentioned this in T1533: Make sure api server uses explicit configurations.Feb 21 2019, 8:34 PM
ardumont mentioned this in D1182: swh.web.config: Allow configuration through environment variable.Feb 23 2019, 1:53 AM

Revision Contents
Changeset List

PathSize
4 lines
swh/
storage/
api/
96 lines
8 lines
25 lines
tests/
129 lines

Diff 3687

View Options

setup.py

Loading...
View Options

swh/storage/api/server.py

Loading...
View Options

swh/storage/api/wsgi.py

Loading...
View Options

swh/storage/cli.py

Loading...
View Options

swh/storage/tests/test_server.py

Loading...
About · Developer information · Legal