Page MenuHomeSoftware Heritage

svn_retry: Reduce max number of retry attempts to 3
ClosedPublic

Authored by anlambert on Dec 7 2022, 6:00 PM.

Details

Summary

Retrying three times is enough as we use expontential backoff.

Previously the loader could be stuck more than twenty minutes in a row
when it encounters a dead external, now it would be a couple of minutes.

Diff Detail

Repository
rDLDSVN Subversion (SVN) loader
Branch
svn-reduce-retry
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 33196
Build 52044: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 52043: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D8946 (id=32223)

Rebasing onto 2b80484b8b...

Current branch diff-target is up to date.
Changes applied before test
commit 7c86dd9eb35854ee0892fdc479e294d1d24ea807
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Dec 7 17:59:42 2022 +0100

    svn_retry: Reduce max number of retry attempts to 3
    
    Retrying three times is enough as we use expontential backoff.
    
    Previously the loader could be stuck more than twenty minutes in a row
    when it encounters a dead external, now it would be a couple of minutes.

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/366/ for more details.

This revision is now accepted and ready to land.Dec 8 2022, 2:29 AM

Build is green

Patch application report for D8946 (id=32241)

Rebasing onto b016f65439...

Current branch diff-target is up to date.
Changes applied before test
commit 91806d44714ab61a206969f775ff77093be2e5a8
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Dec 7 17:59:42 2022 +0100

    svn_retry: Reduce max number of retry attempts to 3
    
    Retrying three times is enough as we use expontential backoff.
    
    Previously the loader could be stuck more than twenty minutes in a row
    when it encounters a dead external, now it would be a couple of minutes.

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/367/ for more details.