Diff Detail
- Repository
- rDDOC Development documentation
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 33186 Build 52029: Phabricator diff pipeline on Jenkins for swh-docs Jenkins console · Jenkins Build 52028: arc lint + arc unit
Event Timeline
Build has FAILED
Patch application report for D8947 (id=32230)
Rebasing onto 7bfdb3d102...
Current branch diff-target is up to date.
Changes applied before test
commit 9c7041abe5dc35ca2682811bddcb6af99e1a1013
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Thu Dec 8 13:12:26 2022 +0100
Document statsd metrics and link to dashboardsLink to build: https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/284/
See console output for more information: https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/284/console
Build is green
Patch application report for D8947 (id=32231)
Rebasing onto 7bfdb3d102...
Current branch diff-target is up to date.
Changes applied before test
commit 704bd38112e6666c32c22b9e7267751d0ed8d2c6
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Thu Dec 8 13:12:26 2022 +0100
Document statsd metrics and link to dashboardsSee https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/285/ for more details.
I like the idea (I'm a bit worried about the list becoming stale really fast, but...)
It'd be useful to keep the commands that you've used to find the metrics in this document. I guess you've been looking for calls to statsd.count/statsd.gauge?
I'm not sure about sticking this at the top level of the toctree (but I don't know where else to put it)
Build is green
Patch application report for D8947 (id=32348)
Rebasing onto 8d04650792...
Current branch diff-target is up to date.
Changes applied before test
commit bd9280191b42c5ce51769c6a188d4e84bcd14889
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Thu Dec 8 13:12:26 2022 +0100
Document statsd metrics and link to dashboardsSee https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/294/ for more details.
lgtm.
I don't know how to address the shortcomings nico mentioned.
Let's figure this out along the way.
one typo inline.
| docs/statsd.rst | ||
|---|---|---|
| 44 | ||
I typed "swh" in the search box of http://pergamon.internal.softwareheritage.org:9090/ then trimmed it manually
I'm not sure about sticking this at the top level of the toctree (but I don't know where else to put it)
We can move it later if needed