Page MenuHomeSoftware Heritage

conftest: Refactor GraphServerProcess to be more flexible
ClosedPublic

Authored by vlorentz on Sep 6 2022, 5:03 PM.

Details

Summary
  1. queue is now encapsulated
  2. object in the queue is now a dict instead of a tuple (to allow adding more keys easily in the future + for readability)

This will be used in a future commit (which will address T4497),
to get the queue's object twice from different functions.

Unit TestsFailed

TimeTest
53,116 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.graph.tests.test_cli::test_pipeline
def test_pipeline(): """run full compression pipeline""" # bare bone configuration, to allow testing the compression pipeline
0 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.graph.tests.test_grpc::test_leaves
@pytest.fixture(scope="module") def graph_grpc_server(): server = GraphServerProcess()
0 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.graph.tests.test_grpc::test_neighbors
@pytest.fixture(scope="module") def graph_grpc_server(): server = GraphServerProcess()
4,210 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.graph.tests.test_grpc::test_stats
@pytest.fixture(scope="module") def graph_grpc_server(): server = GraphServerProcess()
1 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.graph.tests.test_grpc::test_visit_nodes
@pytest.fixture(scope="module") def graph_grpc_server(): server = GraphServerProcess()
View Full Test Results (18 Failed · 12 Passed · 8 Skipped)

Event Timeline

Build has FAILED

Patch application report for D8402 (id=30322)

Rebasing onto dd88f177c3...

Current branch diff-target is up to date.
Changes applied before test
commit 2104133e41a924cf7d2678ac829b5bee44ba2138
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Sep 6 17:02:22 2022 +0200

    conftest: Refactor GraphServerProcess to be more flexible
    
    1. queue is now encapsulated
    2. object in the queue is now a dict instead of a tuple (to allow
       adding more keys easily in the future + for readability)
    
    This will be used in a future commit, to get the queue's object
    twice from different functions.

Link to build: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/218/
See console output for more information: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/218/console

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 6 2022, 5:10 PM
Harbormaster failed remote builds in B31350: Diff 30322!

Build has FAILED

Patch application report for D8402 (id=30325)

Rebasing onto dd88f177c3...

Current branch diff-target is up to date.
Changes applied before test
commit 46255335308446d7b077099fd9b1c68726faf140
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Sep 6 17:02:22 2022 +0200

    conftest: Refactor GraphServerProcess to be more flexible
    
    1. queue is now encapsulated
    2. object in the queue is now a dict instead of a tuple (to allow
       adding more keys easily in the future + for readability)
    
    This will be used in a future commit, to get the queue's object
    twice from different functions.

Link to build: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/221/
See console output for more information: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/221/console

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 6 2022, 5:25 PM
Harbormaster failed remote builds in B31353: Diff 30325!

Build is green

Patch application report for D8402 (id=30329)

Rebasing onto dd88f177c3...

Current branch diff-target is up to date.
Changes applied before test
commit 81d3deb2f1c1b584a076484250cb6f349009f032
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Sep 6 17:02:22 2022 +0200

    conftest: Refactor GraphServerProcess to be more flexible
    
    1. queue is now encapsulated
    2. object in the queue is now a dict instead of a tuple (to allow
       adding more keys easily in the future + for readability)
    
    This will be used in a future commit, to get the queue's object
    twice from different functions.

See https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/224/ for more details.

This revision is now accepted and ready to land.Sep 6 2022, 5:36 PM